[REVIEW] enable multigraph#1280
Merged
BradReesWork merged 10 commits intorapidsai:branch-0.17from Jan 21, 2021
Merged
Conversation
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1280 +/- ##
===============================================
+ Coverage 60.38% 60.70% +0.32%
===============================================
Files 67 67
Lines 3029 3031 +2
===============================================
+ Hits 1829 1840 +11
+ Misses 1200 1191 -9
Continue to review full report at Codecov.
|
BradReesWork
requested review from
a team,
BradReesWork and
afender
and removed request for
a team
BradReesWork
requested changes
Jan 6, 2021
afender
requested changes
Jan 15, 2021
Member
afender
left a comment
afender
left a comment
There was a problem hiding this comment.
I think it is best to capture our multigraph discussions in the form of multigraph class documentation and add it as part of this PR from the start while it is still fresh in our mind.
BradReesWork
approved these changes
Jan 19, 2021
rlratzel
requested changes
Jan 19, 2021
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Looks good, just a few minor requests.
rlratzel
approved these changes
Jan 20, 2021
afender
approved these changes
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.