Skip to content

Update SG PageRank C++ tests#1307

Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-0.18from
seunghwak:bug_pagerank_test
Jan 6, 2021
Merged

Update SG PageRank C++ tests#1307
rapids-bot[bot] merged 7 commits intorapidsai:branch-0.18from
seunghwak:bug_pagerank_test

Conversation

@seunghwak
Copy link
Copy Markdown
Contributor

@seunghwak seunghwak commented Dec 9, 2020

  • Add const to input pointers.
  • Use a double type counter in std::accumulate as std::accumulate is inaccurate in adding a large number of a comparably sized values.
  • Fix random number generator seed.
  • Re-enable a temporarily disabled test case.
  • Relax the thresholds to skip comparison for lowly ranked vertices (with low scores which are more susceptible to the limited floating-point resolution)

@seunghwak seunghwak requested a review from a team as a code owner December 9, 2020 20:18
@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change DO NOT MERGE Hold off on merging; see PR for details labels Dec 9, 2020
@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Dec 10, 2020
@seunghwak seunghwak changed the title [REVIEW] Update SG PageRank C++ tests Update SG PageRank C++ tests Dec 10, 2020
@BradReesWork BradReesWork added this to the 0.18 milestone Dec 10, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1307 (ca89bde) into branch-0.18 (049b088) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.18    #1307   +/-   ##
============================================
  Coverage        60.21%   60.21%           
============================================
  Files               67       67           
  Lines             3049     3049           
============================================
  Hits              1836     1836           
  Misses            1213     1213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049b088...ca89bde. Read the comment docs.

@rapids-bot rapids-bot Bot merged commit 896db87 into rapidsai:branch-0.18 Jan 6, 2021
@seunghwak seunghwak deleted the bug_pagerank_test branch June 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants