Skip to content

[REVIEW] Updates to support nightly MG test automation#1308

Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-0.18from
rlratzel:branch-0.18-mgtestfixes
Jan 4, 2021
Merged

[REVIEW] Updates to support nightly MG test automation#1308
rapids-bot[bot] merged 6 commits intorapidsai:branch-0.18from
rlratzel:branch-0.18-mgtestfixes

Conversation

@rlratzel
Copy link
Copy Markdown
Contributor

This PR includes various updates to support nightly automated MG test runs, including:

  • Adding a marker which nightly scripts use to run on all visible GPUs instead of a hardcoded number of GPUs, since the scripts rely on knowing the number of GPUs being used in the tests by setting the CUDA_VISIBLE_DEVICES env var.
    • In the nightly scripts, the marker is used like so: pytest -m "not preset_gpu_count" ...
  • Added a client.wait_for_workers() call to various setups to both match the approach taken by the MGContext class, and to ensure workers are running. This seemed to increase reliability in the test runs.
    • side note: we should decide to use only the MGContext class or the client_connection pytest fixture in these tests, since they both aim to accomplish the same thing.

…ys use all GPUs) and instead vary GPU count with CUDA_VISIBLE_DEVICES env var, added call to wait_for_workers() for MG test setups.
…" and marked certain MG tests accordingly, and added None as an option to use all visible. This allows nightly tests to set "not preset_gpu_count" to only run on all visible GPUs.
@rlratzel rlratzel requested a review from xcadet December 10, 2020 03:51
@rlratzel rlratzel self-assigned this Dec 10, 2020
@rlratzel rlratzel requested a review from a team as a code owner December 10, 2020 03:51
Comment thread python/cugraph/tests/dask/test_mg_bfs.py Outdated
@BradReesWork BradReesWork added 2 - In Progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 11, 2020
@BradReesWork BradReesWork added this to the 0.18 milestone Dec 14, 2020
@rlratzel rlratzel changed the title [WIP][skip-ci] Updates to support nightly MG test automation [REVIEW] ENH Updates to support nightly MG test automation Dec 29, 2020
@rlratzel
Copy link
Copy Markdown
Contributor Author

rerun tests

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 29, 2020

Codecov Report

Merging #1308 (640b3e1) into branch-0.18 (70d9abd) will decrease coverage by 0.16%.
The diff coverage is 38.09%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #1308      +/-   ##
===============================================
- Coverage        60.38%   60.21%   -0.17%     
===============================================
  Files               67       67              
  Lines             3029     3049      +20     
===============================================
+ Hits              1829     1836       +7     
- Misses            1200     1213      +13     
Impacted Files Coverage Δ
python/cugraph/dask/common/mg_utils.py 37.50% <38.09%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d9abd...640b3e1. Read the comment docs.

Comment thread python/cugraph/tests/dask/test_mg_bfs.py Outdated
Comment thread python/cugraph/tests/dask/test_mg_bfs.py Outdated
@rlratzel rlratzel changed the title [REVIEW] ENH Updates to support nightly MG test automation [REVIEW] Updates to support nightly MG test automation Dec 30, 2020
@rapids-bot rapids-bot Bot merged commit 049b088 into rapidsai:branch-0.18 Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants