Fix EXPERIMENTAL_LOUVAIN_TEST on Pascal#1312
Merged
BradReesWork merged 13 commits intorapidsai:branch-0.18from Jan 5, 2021
Merged
Fix EXPERIMENTAL_LOUVAIN_TEST on Pascal#1312BradReesWork merged 13 commits intorapidsai:branch-0.18from
BradReesWork merged 13 commits intorapidsai:branch-0.18from
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1312 +/- ##
============================================
Coverage 60.38% 60.38%
============================================
Files 67 67
Lines 3029 3029
============================================
Hits 1829 1829
Misses 1200 1200 Continue to review full report at Codecov.
|
rlratzel
reviewed
Dec 17, 2020
rlratzel
approved these changes
Dec 18, 2020
ajschmidt8
approved these changes
Dec 30, 2020
Collaborator
Author
|
rerun tests |
BradReesWork
approved these changes
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experimental::louvainuses acoco::static_mapwhich is not supported on Pascal and earlier GPUs.The first attempt at implementing checks for Pascal attempted to exclusively use preprocessor directives to control building the executable and deciding whether to run it or not. However, nvcc uses the preprocessor to create different files to be compiled for host, and each combination of devices being compiled. Exclusively using preprocessor directives created a library that didn't have all of the host and device code necessary to run.
This PR adds a runtime check to raise an exception if running on Pascal, but it will still compile all of the necessary host and device code for other architectures.