Skip to content

Fix EXPERIMENTAL_LOUVAIN_TEST on Pascal#1312

Merged
BradReesWork merged 13 commits intorapidsai:branch-0.18from
ChuckHastings:fix_experimental_louvain_test
Jan 5, 2021
Merged

Fix EXPERIMENTAL_LOUVAIN_TEST on Pascal#1312
BradReesWork merged 13 commits intorapidsai:branch-0.18from
ChuckHastings:fix_experimental_louvain_test

Conversation

@ChuckHastings
Copy link
Copy Markdown
Collaborator

@ChuckHastings ChuckHastings commented Dec 11, 2020

experimental::louvain uses a coco::static_map which is not supported on Pascal and earlier GPUs.

The first attempt at implementing checks for Pascal attempted to exclusively use preprocessor directives to control building the executable and deciding whether to run it or not. However, nvcc uses the preprocessor to create different files to be compiled for host, and each combination of devices being compiled. Exclusively using preprocessor directives created a library that didn't have all of the host and device code necessary to run.

This PR adds a runtime check to raise an exception if running on Pascal, but it will still compile all of the necessary host and device code for other architectures.

@BradReesWork BradReesWork added this to the 0.18 milestone Dec 11, 2020
@BradReesWork BradReesWork added 2 - In Progress non-breaking Non-breaking change bug Something isn't working labels Dec 11, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 11, 2020

Codecov Report

Merging #1312 (2316f03) into branch-0.18 (70d9abd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.18    #1312   +/-   ##
============================================
  Coverage        60.38%   60.38%           
============================================
  Files               67       67           
  Lines             3029     3029           
============================================
  Hits              1829     1829           
  Misses            1200     1200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d9abd...2316f03. Read the comment docs.

@ChuckHastings ChuckHastings marked this pull request as ready for review December 17, 2020 21:26
@ChuckHastings ChuckHastings requested review from a team as code owners December 17, 2020 21:26
Comment thread cpp/src/experimental/louvain.cuh
Comment thread cpp/tests/experimental/louvain_test.cu
@ChuckHastings
Copy link
Copy Markdown
Collaborator Author

rerun tests

@BradReesWork BradReesWork merged commit d69cff7 into rapidsai:branch-0.18 Jan 5, 2021
@ChuckHastings ChuckHastings deleted the fix_experimental_louvain_test branch February 10, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants