Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1318 +/- ##
===============================================
- Coverage 60.38% 60.06% -0.32%
===============================================
Files 67 67
Lines 3029 3060 +31
===============================================
+ Hits 1829 1838 +9
- Misses 1200 1222 +22
Continue to review full report at Codecov.
|
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
Please see the similar comment on the cuDF PR below about updating the file/path patterns.
BradReesWork
added
improvement
afender
left a comment
afender
left a comment
There was a problem hiding this comment.
I noticed there's no labels for :
docsdatasetsmdfiles
This would be something to consider adding to make sure labels are always auto-created.
| - **/cmake/** | ||
|
|
||
| Java: | ||
| - java/** |
There was a problem hiding this comment.
It should be fine, but just to confirm we do not have a java folder yet.
|
|
||
| python: | ||
| - python/** | ||
| - notebooks/** |
There was a problem hiding this comment.
yes, the benchmark dir is python code we run nightly and as part of CI (in test-only mode) so we'd want that added as well.
|
|
||
| python: | ||
| - python/** | ||
| - notebooks/** |
There was a problem hiding this comment.
yes, the benchmark dir is python code we run nightly and as part of CI (in test-only mode) so we'd want that added as well.
|
|
||
| Ops: | ||
| - .github/** | ||
| - /ci/** |
There was a problem hiding this comment.
I'm assuming this is boilerplate we don't need to review, but the leading / here for the ci folder looked suspicious.
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
I think we should add the benchmark dir.
|
tangential topic: do we have doc owners for review (ie. owners for |
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
one minor change requested. also, can you include a description on the PR?
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Approving assuming AJ's question gets resolved and a description of the PR is added.
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
6 participants
Summary
This PR adds a GitHub action (PR Labeler) to auto label PRs based on a labeling rule and changes in PR.