Skip to content

[REVIEW] Fix graph nodes function and renumbering from series#1319

Merged
BradReesWork merged 9 commits intorapidsai:branch-0.18from
Iroy30:bug_fixes
Jan 12, 2021
Merged

[REVIEW] Fix graph nodes function and renumbering from series#1319
BradReesWork merged 9 commits intorapidsai:branch-0.18from
Iroy30:bug_fixes

Conversation

@Iroy30
Copy link
Copy Markdown
Contributor

@Iroy30 Iroy30 commented Dec 28, 2020

Closes #1316
Closes #1315

@Iroy30 Iroy30 requested a review from a team as a code owner December 28, 2020 19:18
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 28, 2020

Codecov Report

Merging #1319 (dfab2ee) into branch-0.18 (896db87) will increase coverage by 0.73%.
The diff coverage is 30.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #1319      +/-   ##
===============================================
+ Coverage        60.06%   60.80%   +0.73%     
===============================================
  Files               67       67              
  Lines             3060     3013      -47     
===============================================
- Hits              1838     1832       -6     
+ Misses            1222     1181      -41     
Impacted Files Coverage Δ
python/cugraph/structure/graph.py 67.18% <0.00%> (+0.38%) ⬆️
python/cugraph/dask/common/input_utils.py 23.07% <28.57%> (+1.14%) ⬆️
python/cugraph/structure/number_map.py 58.12% <100.00%> (+2.16%) ⬆️
...ython/cugraph/centrality/betweenness_centrality.py 100.00% <0.00%> (ø)
python/cugraph/dask/common/mg_utils.py 40.00% <0.00%> (+2.50%) ⬆️
python/cugraph/utilities/utils.py 71.55% <0.00%> (+4.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896db87...0af875a. Read the comment docs.

@Iroy30 Iroy30 changed the title [WIP] bug fixes [REVIEW] bug fixes Dec 29, 2020
@Iroy30 Iroy30 assigned Iroy30 and unassigned ChuckHastings Jan 4, 2021
@Iroy30 Iroy30 requested a review from ChuckHastings January 4, 2021 05:47
Copy link
Copy Markdown
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few little things

Comment thread CHANGELOG.md Outdated
Comment thread python/cugraph/structure/graph.py
Comment thread python/cugraph/structure/number_map.py
@BradReesWork BradReesWork added bug Something isn't working non-breaking Non-breaking change labels Jan 5, 2021
@BradReesWork
Copy link
Copy Markdown
Member

@Iroy30 with auto-changelog there needs to be a better title since that is what goes into the log

@BradReesWork BradReesWork self-requested a review January 6, 2021 15:41
@Iroy30 Iroy30 changed the title [REVIEW] bug fixes [REVIEW] Fix graph nodes function and renumbering from series Jan 6, 2021
@BradReesWork BradReesWork added this to the 0.18 milestone Jan 12, 2021
@BradReesWork BradReesWork merged commit d53b9cf into rapidsai:branch-0.18 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Renumbering from series failure [BUG] DiGraph.nodes() returns inconsistent values when instantiated from adjacency lists

4 participants