Implement MNMG Renumber#1355
Merged
rapids-bot[bot] merged 56 commits intorapidsai:branch-0.18from Feb 3, 2021
Merged
Conversation
Merge latest release 0.17
Merge latest branch-0.18
Update forked branch-0.18
Update forked branch-0.18 from release
…o enh_ext_mnmg_renumber
BradReesWork
requested review from
BradReesWork,
ChuckHastings,
afender and
rlratzel
BradReesWork
added
improvement
ChuckHastings
requested changes
Jan 25, 2021
Collaborator
ChuckHastings
left a comment
ChuckHastings
left a comment
There was a problem hiding this comment.
Some questions/minor edit suggestions
… a cudf.Series() can be created out of it.
Collaborator
Author
|
rerun tests. |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1355 +/- ##
===============================================
- Coverage 60.38% 59.92% -0.47%
===============================================
Files 67 68 +1
Lines 3029 3084 +55
===============================================
+ Hits 1829 1848 +19
- Misses 1200 1236 +36
Continue to review full report at Codecov.
|
ChuckHastings
requested changes
Feb 3, 2021
Collaborator
ChuckHastings
left a comment
ChuckHastings
left a comment
There was a problem hiding this comment.
One minor concern
seunghwak
approved these changes
Feb 3, 2021
afender
approved these changes
Feb 3, 2021
Member
afender
left a comment
afender
left a comment
There was a problem hiding this comment.
Looks good considering integration and testing will be addressed in a future PR
ChuckHastings
approved these changes
Feb 3, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes to cython / python newly added C++ functions
sort_and_shuffle_values()andrenumber_edgelist()in order to perform MNMG renumbering.