Update CMakeLists.txt files for consistency with RAPIDS and to support cugraph as an external project and other tech debt removal#1367
Merged
rapids-bot[bot] merged 17 commits intorapidsai:branch-0.18from Feb 4, 2021
Conversation
…, replaced usage of CMAKE_SOURCE_DIR with CMAKE_CURRENT_SOURCE_DIR and added project() lines to thirdparty packages to better support users including cugraph as a 3rd party project in their applications (and for consistency with RAPIDS).
…e requirement back to thirdparty modules to remove warning.
rlratzel
added
3 - Ready for Review
improvement
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1367 +/- ##
===============================================
- Coverage 60.38% 59.92% -0.47%
===============================================
Files 67 68 +1
Lines 3029 3084 +55
===============================================
+ Hits 1829 1848 +19
- Misses 1200 1236 +36
Continue to review full report at Codecov.
|
ChuckHastings
approved these changes
Feb 1, 2021
Collaborator
ChuckHastings
left a comment
ChuckHastings
left a comment
There was a problem hiding this comment.
One little thing would be nice.
…env file (rapids docs meta pacakge is now recommended)
…ated the conda dev env files accordingly.
…es with gunrock cmake files), updated python setup utils to understand new FetchContent dirs and syntax when reading from CMakeLists.txt
…-source as part of the libcugraph build.
…t of libcugraph conda build.
rlratzel
changed the title
ajschmidt8
approved these changes
Feb 3, 2021
Member
|
@gpucibot merge |
BradReesWork
requested changes
Feb 3, 2021
BradReesWork
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes cuGraph's cmake files more consistent with other RAPIDS libs by matching the minimum required cmake version, adding
project()statements to cugraph's thirdparty modules, and usingCMAKE_CURRENT_SOURCE_DIRappropriately so paths are relative to the CMakeLists.txt file rather than the top-level cmake dir of the project (since that may not be the cugraph cpp dir in the case of cugraph being used as an external project by another application).This also adds a
CUDA_ARCHITECTURES=OFFsetting to suppress the warning printed for each test target. This setting may be replaced/changed once the findcudatoolkit feature is used in a future cmake version.This also removes the Arrow and GTest cmake files since Arrow is not a direct dependency and those files were not being used, and GTest is now a build requirement in the conda dev environment and does not need to be built from source (the conda dev env files have been updated accordingly).
This PR also addresses much of #1075 , but not completely since gunrock is still using
ExternalProjectdue to (I think) updates that need to be made to their cmake files to support this.This was tested by observing a successful clean build, however it was not tested by creating a separate cmake application to simulate cugraph being used as a 3rd party package.
Note: the changes in this PR were modeled after rapidsai/rmm#541
closes #1137
closes #1266