Rename sort_and_shuffle to groupby_gpuid_and_shuffle#1392
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-0.19from Feb 22, 2021
Merged
Rename sort_and_shuffle to groupby_gpuid_and_shuffle#1392rapids-bot[bot] merged 4 commits intorapidsai:branch-0.19from
rapids-bot[bot] merged 4 commits intorapidsai:branch-0.19from
Conversation
seunghwak
added
3 - Ready for Review
improvement
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #1392 +/- ##
==============================================
Coverage ? 60.72%
==============================================
Files ? 70
Lines ? 3132
Branches ? 0
==============================================
Hits ? 1902
Misses ? 1230
Partials ? 0 Continue to review full report at Codecov.
|
ChuckHastings
approved these changes
Feb 18, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename to better reflect what this function should do than how it is currently implemented (which can change in the future for better performance).