Skip to content

Add additional datasets to improve coverage#1441

Merged
rapids-bot[bot] merged 30 commits intorapidsai:branch-0.19from
jnke2016:branch-0.19-add_datasets_coverage
Mar 18, 2021
Merged

Add additional datasets to improve coverage#1441
rapids-bot[bot] merged 30 commits intorapidsai:branch-0.19from
jnke2016:branch-0.19-add_datasets_coverage

Conversation

@jnke2016
Copy link
Copy Markdown
Contributor

@jnke2016 jnke2016 commented Mar 7, 2021

add datasets to test self-loops, string vertex IDs and isolated vertices
Update README
closes #1214

jnke2016 and others added 16 commits March 7, 2021 16:22
@jnke2016
add datasets to test self-loops, string vertex IDs and isolated vertices
ca8b1ab
@jnke2016
add datasets to test self-loops, string vertex IDs and isolated vertices
6bd701c
@jnke2016
add datasets to test self-loops, string vertex IDs and isolated vertices
f8fe57f
@jnke2016
test
22e6f5b
@jnke2016
add datasets to test self-loops, string vertex IDs, isolated vertices
88d5ed5
@jnke2016
Update README.md
e86b542 
add datasets to test self-loops, string vertex IDs and isolated vertices 
Update README 
closes rapidsai#1214
@jnke2016
Update README.md
35545b4 
add datasets to test self-loops, string vertex IDs and isolated vertices 
Update README 
closes rapidsai#1214
@jnke2016
Update README.md
e8ddf4b 
add datasets to test self-loops, string vertex IDs and isolated vertices 
Update README
closes rapidsai#1214
@jnke2016
Add files via upload
aa1cba7 
add datasets to test self-loops, string vertex IDs and isolated vertices
Update README
closes rapidsai#1214
@jnke2016
Delete ca-AstroPh.csv
273eded
@jnke2016
Delete ca-CondMat.csv
6d1ba53
@jnke2016
Delete ca-GrQc.csv
b7902ae
@jnke2016
Delete ca-HepTh.csv
f61b6ac
@jnke2016
Delete karate_mod.mtx
c30bef2
@jnke2016
Delete karate_str.mtx
b73bde6
@jnke2016
adding datasets for coverage
d00558a 
add datasets to test self-loops, string vertex IDs and isolated vertices
Update README
closes rapidsai#1214
@jnke2016 jnke2016 requested review from a team as code owners March 7, 2021 22:29
@jnke2016
Copy link
Copy Markdown
Contributor Author

jnke2016 commented Mar 7, 2021 •
edited
Loading

One of the files (out of 6) I uploaded is above the 5242880 limit (the file is 5.3 MB). Should I just delete that file or include the file and update the download script ?

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 9, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 9, 2021
@BradReesWork
Copy link
Copy Markdown
Member

BradReesWork commented Mar 9, 2021

@jnke2016 this explodes the size of data in the repo which affects packaging size. Should some of these files be moved to the S3 drive and downloaded like we do for scale testing?

Is simply modifying the smaller karate dataset not enough?

@BradReesWork BradReesWork changed the title Branch 0.19 add datasets coverage Add additiomal datasets to improve coverage Mar 9, 2021
@BradReesWork BradReesWork changed the title Add additiomal datasets to improve coverage Add additional datasets to improve coverage Mar 9, 2021
BradReesWork
BradReesWork requested changes Mar 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the large files need to be removed. you can add them to the S3 store

Comment thread datasets/README.md Outdated



## Tests coverage
Copy link
Copy Markdown
Member

@BradReesWork BradReesWork Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reference section under docs where we list all the test files used. Adding info on the files is nice

Copy link
Copy Markdown
Contributor Author

@jnke2016 jnke2016 Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR, I updated datasets/README.md to reference and describe the new datasets. But after discussing with Rick, I instead modified the existing datasets (karate, dolphins) since they are much smaller, therefore easier to test. I will be uploading the new datasets in this PR

BradReesWork
BradReesWork requested changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

large datasets need to be removed

jnke2016 and others added 13 commits March 11, 2021 22:41
@jnke2016
added datasets to test self-loops, isolated vertices, string vertex I…
eab8768 
…Ds, multi-edges
@jnke2016
added datasets to test self-loops, isolated vertices, string vertex I…
a36c618 
…Ds, multi-edges
@jnke2016
Merge remote-tracking branch 'upstream/branch-0.19' into branch-0.19-…
fd4835a 
…add_datasets_coverage
@jnke2016
added datasets to test self-loops, isolated vertices, string vertex I…
3d0db18 
…Ds, multi-edges
@jnke2016
added datasets to test self-loops, isolated vertices, string vertex I…
5208be0 
…Ds, multi-edges
@jnke2016
Add additional datasets to improve coverage
46b8811 
added datasets to test self-loops, isolated vertices, string vertex IDs, multi-edges
Updated download script accordingly
Updated README accordingly
closes rapidsai#1214
@jnke2016
Add additional datasets to improve coverage
057f62c 
Added datasets to test self-loops, isolated vertices, string vertex IDs, multi-edges
Updated download script accordingly
Updated README accordingly
closes rapidsai#1214
@jnke2016
Add additional datasets to improve coverage
54b93b2 
Added datasets to test self-loops, isolated vertices, string vertex IDs, multi-edges
Updated download script accordingly
Updated README accordingly
closes rapidsai#1214
@jnke2016
Delete ca-AstroPh.csv
46454ab
@jnke2016
Delete ca-CondMat.csv
ef8e382
@jnke2016
Delete ca-GrQc.csv
3e7a78a
@jnke2016
Delete ca-HepTh.csv
d9c05c6
@jnke2016
Add additional datasets to improve coverage
be40a67 
Added datasets to test self-loops, isolated vertices, string vertex IDs, multi-edges
Updated download script accordingly
Updated README accordingly
closes rapidsai#1214
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 12, 2021 •
edited
Loading

Codecov Report

Merging #1441 (be40a67) into branch-0.19 (4535396) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #1441      +/-   ##
===============================================
+ Coverage        60.72%   60.78%   +0.05%     
===============================================
  Files               70       70              
  Lines             3132     3134       +2     
===============================================
+ Hits              1902     1905       +3     
+ Misses            1230     1229       -1
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️
python/cugraph/utilities/utils.py 72.44% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4535396...be40a67. Read the comment docs.

rlratzel
rlratzel requested changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a few minor requests.

Comment thread datasets/README.md
Comment thread datasets/README.md Outdated
Comment thread datasets/README.md Outdated
Comment thread datasets/README.md Outdated
@jnke2016
Add additional datasets to improve coverage
4d6b576 
added datasets to test self-loops, isolated vertices, string vertex IDs, multi-edges
Updated download script accordingly
Updated README accordingly
closes rapidsai#1214
@BradReesWork
Copy link
Copy Markdown
Member

BradReesWork commented Mar 18, 2021

@gpucibot merge

@rapids-bot rapids-bot Bot merged commit ab4b77b into rapidsai:branch-0.19 Mar 18, 2021
@BradReesWork BradReesWork linked an issue Mar 29, 2021 that may be closed by this pull request
[ENH] Add additional datasets for increased test coverage #1349
Closed
@jnke2016 jnke2016 deleted the branch-0.19-add_datasets_coverage branch September 24, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlratzel rlratzel rlratzel approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@Iroy30 Iroy30 Awaiting requested review from Iroy30

Assignees

@jnke2016 jnke2016

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

[ENH] Add additional datasets for increased test coverage Test with isolated vertices and self loops

4 participants

@jnke2016 @BradReesWork @codecov-io @rlratzel