Remove literals passed to device_uvector::set_element_async#1453
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-0.19from Mar 17, 2021
Merged
Conversation
BradReesWork
added
improvement
BradReesWork
added
DO NOT MERGE
seunghwak
approved these changes
Mar 16, 2021
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Thanks for the update!
aschaffer
approved these changes
Mar 16, 2021
Member
Author
|
codecov failing to connect in CI? |
Member
Author
|
rerun tests |
Member
Author
|
@BradReesWork this should be safe to merge and good to get it in before RMM #725 merges. Why the DO NOT MERGE label? |
Member
|
@harrism I marked it as blocked based on your comment "After rapidsai/rmm#725 is merged," If there is not an issue for cuGraph, then I'll merge it now |
BradReesWork
removed
Blocked
Member
|
@gpucibot merge |
Member
Author
|
Ah sorry, I meant RMM 725 would break cuGraph build if merged, but this was safe before and after 725. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After rapidsai/rmm#725 is merged, this PR updates cuspatial to eliminate passing literal values to device_uvector::set_element_async.
Companion PR to rapidsai/cuspatial#367