Skip to content

Miscellaneous bug fixes#1561

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-0.20from
seunghwak:bug_misc
Apr 29, 2021
Merged

Miscellaneous bug fixes#1561
rapids-bot[bot] merged 4 commits intorapidsai:branch-0.20from
seunghwak:bug_misc

Conversation

@seunghwak
Copy link
Copy Markdown
Contributor

@seunghwak seunghwak commented Apr 26, 2021

Miscellaneous bug fixes: a compile error with CUDA 11.2 and a typo.

@seunghwak seunghwak requested a review from a team as a code owner April 26, 2021 21:35
@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Apr 26, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.20@f6cecf5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.20    #1561   +/-   ##
==============================================
  Coverage               ?   60.26%           
==============================================
  Files                  ?       73           
  Lines                  ?     3214           
  Branches               ?        0           
==============================================
  Hits                   ?     1937           
  Misses                 ?     1277           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cecf5...9f43824. Read the comment docs.

vertex_t{0});

rmm::device_uvector<size_t> map(max, size_t{0});
rmm::device_uvector<size_t> map(max, cudaStream_t{nullptr});
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use handle.get_stream() here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we SHOULD.

@BradReesWork
Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot rapids-bot Bot merged commit 8c23813 into rapidsai:branch-0.20 Apr 29, 2021
@seunghwak seunghwak deleted the bug_misc branch June 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants