Undo disabling MG C++ testing outputs for non-root processes#1615
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.06from May 25, 2021
Merged
Conversation
Contributor
Author
|
Submitted #1616 for a longer term solution to disable only redundant test progress messages. |
ChuckHastings
approved these changes
May 24, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #1615 +/- ##
===============================================
Coverage ? 59.10%
===============================================
Files ? 79
Lines ? 3482
Branches ? 0
===============================================
Hits ? 2058
Misses ? 1424
Partials ? 0 Continue to review full report at Codecov.
|
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling MG C++ testing outputs for non-root processes has an undesirable side effect of disabling error messages (e.g. exception outputs) as well. This makes failure diagnosis difficult in large-scale runs.
Delete the code disabling MG C++ testing outputs for non-root processes in this PR. In long run, we need a more elegant mechanism to disable only redundant test progress messages while still allowing error messages to be displayed.