Skip to content

[HOTFIX] Bug fix in triangle counting#1654

Merged
raydouglass merged 2 commits intorapidsai:branch-21.06from
ChuckHastings:bug_triangle_counting_overflow
Jun 8, 2021
Merged

[HOTFIX] Bug fix in triangle counting#1654
raydouglass merged 2 commits intorapidsai:branch-21.06from
ChuckHastings:bug_triangle_counting_overflow

Conversation

@ChuckHastings
Copy link
Copy Markdown
Collaborator

Optimizations in the triangle counting logic did computations using available memory to determine the number of cuda blocks to use.

Computation was using a 32-bit integer and on an 80 GB memory system would overflow and generate a negative number - causing a crash.

Adjusted the computation to be done as size_t and cast to an int after determining the number of blocks.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 8, 2021 00:54
@ChuckHastings ChuckHastings self-assigned this Jun 8, 2021
@ChuckHastings ChuckHastings added ! - Hotfix bug Something isn't working labels Jun 8, 2021
@ChuckHastings ChuckHastings added this to the 21.06 milestone Jun 8, 2021
@ChuckHastings ChuckHastings added the non-breaking Non-breaking change label Jun 8, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1654 (2d79697) into branch-21.06 (57ee866) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.06    #1654      +/-   ##
================================================
- Coverage         59.79%   59.77%   -0.03%     
================================================
  Files                80       80              
  Lines              3542     3540       -2     
================================================
- Hits               2118     2116       -2     
  Misses             1424     1424              
Impacted Files Coverage Δ
python/cugraph/_version.py 44.40% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ee866...2d79697. Read the comment docs.

@BradReesWork BradReesWork changed the title Bug fix in triangle counting [HOTFIX] Bug fix in triangle counting Jun 8, 2021
@raydouglass raydouglass merged commit b0faf21 into rapidsai:branch-21.06 Jun 8, 2021
@ChuckHastings ChuckHastings deleted the bug_triangle_counting_overflow branch July 29, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants