[HOTFIX] Bug fix in triangle counting#1654
Merged
raydouglass merged 2 commits intorapidsai:branch-21.06from Jun 8, 2021
Merged
[HOTFIX] Bug fix in triangle counting#1654raydouglass merged 2 commits intorapidsai:branch-21.06from
raydouglass merged 2 commits intorapidsai:branch-21.06from
Conversation
…utation would support
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #1654 +/- ##
================================================
- Coverage 59.79% 59.77% -0.03%
================================================
Files 80 80
Lines 3542 3540 -2
================================================
- Hits 2118 2116 -2
Misses 1424 1424
Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizations in the triangle counting logic did computations using available memory to determine the number of cuda blocks to use.
Computation was using a 32-bit integer and on an 80 GB memory system would overflow and generate a negative number - causing a crash.
Adjusted the computation to be done as
size_tand cast to an int after determining the number of blocks.