Skip to content

ReduceV test#1710

Merged
rapids-bot[bot] merged 16 commits intorapidsai:branch-21.08from
kaatish:reduce_v_test
Jul 28, 2021
Merged

ReduceV test#1710
rapids-bot[bot] merged 16 commits intorapidsai:branch-21.08from
kaatish:reduce_v_test

Conversation

@kaatish
Copy link
Copy Markdown
Collaborator

@kaatish kaatish commented Jul 13, 2021

Added test for reduce_v primitive.

@kaatish kaatish requested review from a team as code owners July 13, 2021 20:18
@kaatish kaatish changed the title ReduceV test [WIP] [skip-ci] ReduceV test Jul 13, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 13, 2021 •
edited
Loading

Codecov Report

Merging #1710 (f605006) into branch-21.08 (9bcfa14) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

❗ Current head f605006 differs from pull request most recent head 8b851b1. Consider uploading reports for the commit 8b851b1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1710      +/-   ##
================================================
- Coverage         59.82%   59.75%   -0.08%     
================================================
  Files                77       77              
  Lines              3515     3523       +8     
================================================
+ Hits               2103     2105       +2     
- Misses             1412     1418       +6
Impacted Files Coverage Δ
python/cugraph/dask/common/part_utils.py 20.16% <20.00%> (-0.50%) ⬇️
python/cugraph/dask/common/input_utils.py 21.73% <28.57%> (-0.59%) ⬇️
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcfa14...8b851b1. Read the comment docs.

@BradReesWork BradReesWork added 2 - In Progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 14, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jul 14, 2021
@kaatish kaatish changed the title [WIP] [skip-ci] ReduceV test ReduceV test Jul 15, 2021
@seunghwak seunghwak self-requested a review July 15, 2021 19:26
seunghwak
seunghwak reviewed Jul 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

I just left one comment, and besides that one, I have no complaint.

Comment thread cpp/tests/prims/mg_reduce_v.cu Outdated
seunghwak
seunghwak reviewed Jul 15, 2021
View reviewed changes
Comment thread cpp/tests/prims/mg_reduce_v.cu Outdated
seunghwak
seunghwak reviewed Jul 16, 2021
View reviewed changes
Comment thread cpp/include/cugraph/prims/reduce_v.cuh Outdated
Comment thread cpp/include/cugraph/prims/reduce_v.cuh Outdated
seunghwak
seunghwak reviewed Jul 26, 2021
View reviewed changes
Comment thread cpp/include/cugraph/prims/reduce_v.cuh Outdated
seunghwak
seunghwak approved these changes Jul 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!! I have few minor comments but beside those, this looks great to me.

Comment thread cpp/include/cugraph/prims/count_if_e.cuh
Comment thread cpp/include/cugraph/prims/copy_v_transform_reduce_in_out_nbr.cuh Outdated
@ChuckHastings
Copy link
Copy Markdown
Collaborator

ChuckHastings commented Jul 27, 2021

rerun tests

2 similar comments
@ChuckHastings
Copy link
Copy Markdown
Collaborator

ChuckHastings commented Jul 27, 2021

rerun tests

@ChuckHastings
Copy link
Copy Markdown
Collaborator

ChuckHastings commented Jul 27, 2021

rerun tests

@BradReesWork
Copy link
Copy Markdown
Member

BradReesWork commented Jul 28, 2021

@gpucibot merge

@rapids-bot rapids-bot Bot merged commit e074f82 into rapidsai:branch-21.08 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@kaatish kaatish

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

21.08

Development

Successfully merging this pull request may close these issues.

6 participants

@kaatish @codecov-commenter @ChuckHastings @BradReesWork @seunghwak @caryr35