[FIX] Remove -g from cython compile commands#1783
Merged
ajschmidt8 merged 3 commits intorapidsai:branch-21.08from Aug 25, 2021
Merged
[FIX] Remove -g from cython compile commands#1783ajschmidt8 merged 3 commits intorapidsai:branch-21.08from
ajschmidt8 merged 3 commits intorapidsai:branch-21.08from
Conversation
ajschmidt8
added
improvement
trxcllnt
added
2 - In Progress
DO NOT MERGE
trxcllnt
added
3 - Ready for Review
and removed
2 - In Progress
DO NOT MERGE
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #1783 +/- ##
================================================
- Coverage 59.85% 59.73% -0.12%
================================================
Files 77 77
Lines 3547 3549 +2
================================================
- Hits 2123 2120 -3
- Misses 1424 1429 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
-gfrom the compile commands generated by distutils to compile Cython files.This will make our container images, conda packages, and python wheels smaller.
Before this change:
After this change: