[HOTFIX] Changed code to disable k_truss on CUDA 11.4 differently#1813
Merged
ajschmidt8 merged 1 commit intorapidsai:branch-21.08from Sep 16, 2021
Merged
Conversation
raydouglass
approved these changes
Sep 10, 2021
BradReesWork
approved these changes
Sep 15, 2021
Member
|
@raydouglass you need to merge this since I do not have permissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed code to disable
k_trusson CUDA 11.4 to not usenumba.cuda.runtime.get_version()at import time since this creates a CUDA context which breaks daskLocalCUDAClusterinit (causes a nccl init invalid usage exception).This code change results in almost the same UX as before, except explicit imports of the
k_trussmodule no longer raise the exception immediately, and instead raise only when ak_trussalgo is called.Tested by ensuring unit tests for the conditional enabling of k_truss still work and also checked that a
LocalCUDAClustercould properly be created.See #1811 for reference