Forward merge branch-24.06 into branch-24.08#4489
Merged
rapids-bot[bot] merged 20 commits intorapidsai:branch-24.08from Jun 19, 2024
Merged
Forward merge branch-24.06 into branch-24.08#4489rapids-bot[bot] merged 20 commits intorapidsai:branch-24.08from
rapids-bot[bot] merged 20 commits intorapidsai:branch-24.08from
Conversation
…#4475) Addresses rapidsai#4474 Currently `openmpi=5.0.3-hfd7b305_105` is blocking our CI `cpp_build` job. Most likely introduced by this PR: conda-forge/openmpi-feedstock#158 This PR will unblock cugraph development until the issues are fixed. Once that happens, the version pinning should be removed.
…sai#4464) PyTorch 2.2+ is incompatible with the NCCL version on our containers. Normally, this would not be an issue, but there is a bug in CuPy that loads the system NCCL instead of the user NCCL. This PR binds the PyTorch test dependency version to get around this issue. --------- Co-authored-by: Bradley Dice <bdice@bradleydice.com> Co-authored-by: Ralph Liu <137829296+nv-rliu@users.noreply.github.com> Co-authored-by: James Lamb <jlamb@nvidia.com>
alexbarghi-nv
added
feature request
Member
|
@nv-rliu I think this should be renamed "Forward merge branch-24.06 into branch-24.08 |
tingyu66
changed the title
Closed
ajschmidt8
reviewed
Jun 17, 2024
Comment on lines
+60
to
+61
| PARALLEL_LEVEL=$(python -c \ | ||
| "from math import ceil; from multiprocessing import cpu_count; print(ceil(cpu_count()/2))") |
Member
There was a problem hiding this comment.
we recently added a PARALLEL_LEVEL environment variable to the rapids-configure-sccache script below:
That script is sourced earlier in this file.
Therefore you could simply use the value defined from that script instead of redefining it here.
Member
There was a problem hiding this comment.
Great. Just wanted to be aggressive here to rule out the impact of hyperthreading. Using all 64 logical cores to compile cugraph did fail at times on my workstation (w/ Threadripper 3975WX).
Contributor
There was a problem hiding this comment.
I don't think hyperthreading is a factor on these CI machines -- we get the "real" number of cores, afaik. We should be safe to remove this. Let's wait to push until after CI runs on the current commit (I'm testing something else at the moment).
bdice
reviewed
Jun 17, 2024
ChuckHastings
approved these changes
Jun 19, 2024
Contributor
|
I'm going to go ahead and trigger a merge. Builds all succeeded. |
bdice
approved these changes
Jun 19, 2024
Contributor
|
/merge |
nv-rliu
added a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
Replaces rapidsai/cugraph#4476 Authors: - Ralph Liu (https://github.com/nv-rliu) - Alex Barghi (https://github.com/alexbarghi-nv) - Tingyu Wang (https://github.com/tingyu66) - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) - Bradley Dice (https://github.com/bdice) URL: rapidsai/cugraph#4489
nv-rliu
added a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
Replaces rapidsai/cugraph#4476 Authors: - Ralph Liu (https://github.com/nv-rliu) - Alex Barghi (https://github.com/alexbarghi-nv) - Tingyu Wang (https://github.com/tingyu66) - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) - Bradley Dice (https://github.com/bdice) URL: rapidsai/cugraph#4489
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #4476