Skip to content

hide RAFT #pragma deprecation warnings#114

Merged
rapids-bot[bot] merged 8 commits intobranch-24.06from
fix/hide-raft-deprecation-warnings
May 23, 2024
Merged

hide RAFT #pragma deprecation warnings#114
rapids-bot[bot] merged 8 commits intobranch-24.06from
fix/hide-raft-deprecation-warnings

Conversation

@trxcllnt
Copy link
Copy Markdown
Contributor

Define -DRAFT_HIDE_DEPRECATION_WARNINGS added in rapidsai/raft#2271.

@trxcllnt trxcllnt requested a review from a team as a code owner May 10, 2024 19:15
@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 10, 2024
@trxcllnt
Copy link
Copy Markdown
Contributor Author

Seems like raft headers have code that triggers warnings. Since the pip builds add raft as a CMake submodule, the raft includes are added as -I instead of -isystem, so raft warnings are failing the -Werror cuvs build.

Doesn't raft build with -Werror? It seems like any raft warnings should have been caught in the raft CI before being merged?

@trxcllnt trxcllnt requested a review from a team as a code owner May 13, 2024 19:17
@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented May 23, 2024

/merge

@rapids-bot rapids-bot Bot merged commit ac85fa6 into branch-24.06 May 23, 2024
@trxcllnt trxcllnt deleted the fix/hide-raft-deprecation-warnings branch May 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants