[REVIEW] Move from thrust::make_counting_iterator to cuda::make_counting_iterator#1826
Merged
rapids-bot[bot] merged 5 commits intorapidsai:mainfrom Feb 23, 2026
Merged
Conversation
This commit fixes the compile error one sees because of the use of `thrust::make_counting_iterator`: ``` │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: namespace "thrust" has no member "make_counting_iterator" │ │ auto count = thrust::make_counting_iterator<IndexType>(0); │ │ ^ │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: type name is not allowed │ │ auto count = thrust::make_counting_iterator<IndexType>(0); ``` The RAPIDS projects seem to be moving away from using the thrust function, and switching to the cuda version of the same. This change moves cuVS in that direction. Signed-off-by: MithunR <mithunr@nvidia.com>
mythrocks
added
bug
mythrocks
changed the title
thrust::make_counting_iteratorthrust::make_counting_iterator
Merged
mythrocks
changed the title
thrust::make_counting_iteratorthrust::make_counting_iterator to cuda::make_counting_iterator
Contributor
Author
|
/ok to test dae9f7a |
divyegala
requested changes
Feb 20, 2026
Member
divyegala
left a comment
divyegala
left a comment
There was a problem hiding this comment.
Can you do a more comprehensive update across the codebase please? https://github.com/search?q=repo%3Arapidsai%2Fcuvs%20counting_iterator&type=code
Signed-off-by: MithunR <mithunr@nvidia.com>
Signed-off-by: MithunR <mithunr@nvidia.com>
Contributor
Author
|
/ok to test 88cc38a |
Contributor
Author
|
divyegala
approved these changes
Feb 21, 2026
Member
|
/merge |
tfeher
pushed a commit
to Stardust-SJF/cuvs_rabitq
that referenced
this pull request
Mar 3, 2026
…unting_iterator` (rapidsai#1826) This commit moves the use of `thrust::make_counting_iterator` to `cuda::make_counting_iterator`, much like in rapidsai/raft#2958. This change was initally done to fix the compile error one saw because of the use of `thrust::make_counting_iterator`: ``` │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: namespace "thrust" has no member "make_counting_iterator" │ │ auto count = thrust::make_counting_iterator<IndexType>(0); │ │ ^ │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: type name is not allowed │ │ auto count = thrust::make_counting_iterator<IndexType>(0); ``` The RAPIDS projects seem to be moving away from using the thrust function, and switching to the cuda version of the same. (Refer to rapidsai/raft#2958.) This change moves cuVS in that direction. Authors: - MithunR (https://github.com/mythrocks) Approvers: - Jinsol Park (https://github.com/jinsolp) - Divye Gala (https://github.com/divyegala) URL: rapidsai#1826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the use of
thrust::make_counting_iteratortocuda::make_counting_iterator, much like in rapidsai/raft#2958.This change was initally done to fix the compile error one saw because of the use of
thrust::make_counting_iterator:The RAPIDS projects seem to be moving away from using the thrust function, and switching to the cuda version of the same. (Refer to rapidsai/raft#2958.) This change moves cuVS in that direction.