Exposition of KMeans param object for PQ#2005
Open
lowener wants to merge 6 commits intorapidsai:mainfrom
Open
Conversation
Signed-off-by: Mickael Ide <mide@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
lowener
added
breaking
Signed-off-by: Mickael Ide <mide@nvidia.com>
Signed-off-by: Mickael Ide <mide@nvidia.com>
tarang-jain
reviewed
Apr 16, 2026
Contributor
tarang-jain
left a comment
tarang-jain
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this! I just added a comment about one small thing. Apart from that, I have no issues with this PR.
| std::min<uint32_t>(in_params.max_train_points_per_pq_code, | ||
| n_rows * in_params.pq_kmeans_trainset_fraction / pq_n_centers), | ||
| std::min<uint32_t>(in_params.max_train_points_per_vq_cluster, | ||
| n_rows * in_params.vq_kmeans_trainset_fraction / in_params.vq_n_centers)}; |
Contributor
There was a problem hiding this comment.
Could vq_n_centers be set to zero. Perhaps we can just add a guard to avoid zero division.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1999