Skip to content

Normalize whitespace#593

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.02from
bdice:trim-whitespace
Jan 25, 2025
Merged

Normalize whitespace#593
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.02from
bdice:trim-whitespace

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Jan 20, 2025

This PR applies pre-commit hooks to normalize whitespace (trimming trailing whitespace and enforcing consistent end-of-file newlines).

These rules are already applied to most other RAPIDS repos, so this PR aligns with the norm in RAPIDS.

@bdice bdice requested review from a team as code owners January 20, 2025 20:32
@bdice bdice requested a review from jameslamb January 20, 2025 20:32
@bdice bdice self-assigned this Jan 20, 2025
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 20, 2025
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly support this, thank you for doing it.

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 23, 2025

Looks like a style checker failed

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jan 25, 2025

/merge

@rapids-bot rapids-bot bot merged commit c01c7ca into rapidsai:branch-25.02 Jan 25, 2025
narangvivek10 pushed a commit to SearchScale/cuvs that referenced this pull request Jan 27, 2025
This PR applies `pre-commit` hooks to normalize whitespace (trimming trailing whitespace and enforcing consistent end-of-file newlines).

These rules are already applied to most other RAPIDS repos, so this PR aligns with the norm in RAPIDS.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants