Port C++ CAGRA runtime from RAFT#8
Closed
lowener wants to merge 13 commits intorapidsai:branch-24.02from
Closed
Conversation
Signed-off-by: Mickael Ide <mide@nvidia.com>
cjnolet
reviewed
Jan 16, 2024
Member
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
Looking great so far! I wanted to share some initial feedback early.
I think we should go ahead and remove all of the headers from the detail namespace and any of the public headers that we're not using. I had originally copied the entire RAFT repo over thinking it might be easy just to rename the VSS bits but it proved harder than I had hoped.
| src/neighbors/detail/cagra/search_single_cta_float_uint64_dim512_t32.cu | ||
| src/neighbors/detail/cagra/search_single_cta_float_uint64_dim1024_t32.cu | ||
| #test/neighbors/ann_cagra/test_float_int64_t.cu | ||
| #src/neighbors/detail/cagra/search_multi_cta_float_uint64_dim128_t8.cu |
Member
There was a problem hiding this comment.
We should move the relevant tests over so that we can test end-to-end w/ the new cuvs::neighbors public API.
Contributor
Author
There was a problem hiding this comment.
I kept test/neighbors/ann_cagra to test end-to-end CAGRA
Signed-off-by: Mickael Ide <mide@nvidia.com>
cjnolet
added
improvement
Signed-off-by: Mickael Ide <mide@nvidia.com>
Member
|
Changes have been merged into #27. Closing this one for now. |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Bruteforce API implementation Co-authored-by: Vivek Narang <vivek@searchscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is porting the CAGRA runtime API from RAFT to cuVS.