remove top-level Dockerfile#399
Merged
jacobtomlinson merged 1 commit intorapidsai:mainfrom Jul 25, 2024
jameslamb:remove-dockerfile
Merged
remove top-level Dockerfile#399jacobtomlinson merged 1 commit intorapidsai:mainfrom jameslamb:remove-dockerfile
jacobtomlinson merged 1 commit intorapidsai:mainfrom
jameslamb:remove-dockerfile
Conversation
jameslamb
added
improvement
jacobtomlinson
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contributes to #398 (by removing a stray reference to Python 3.7)
As far as I can tell, the
Dockerfileat the repo is not used for anything.It was checked in 2 years ago in #42, and hasn't been modified since. Even there, it doesn't look like it was used for anything.
That PR was called "Add GCP Vertex AI docs". The Vertex docs here don't rely on it: https://github.com/rapidsai/deployment/blob/main/source/cloud/gcp/vertex-ai.md.
I don't see any other obvious uses searching around the repo like this:
git grep 'docker build' git grep DockerfileI think it can and should be removed.