add pr-builder job#693
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from Jul 19, 2024
jameslamb:ci/pr-builder
Merged
add pr-builder job#693rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from jameslamb:ci/pr-builder
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from
jameslamb:ci/pr-builder
Conversation
raydouglass
approved these changes
Jul 19, 2024
Contributor
raydouglass
left a comment
raydouglass
left a comment
There was a problem hiding this comment.
One nitpick, but approving otherwise.
Member
Author
|
Ok sure, no problem. I'd put But I don't feel that strongly about it. |
Contributor
|
/merge |
Member
|
Thanks James and Ray! 🙏 |
This was referenced Aug 14, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Follow-up to #702 and #693. Created based on #696 (comment) `test` jobs are not currently running on pull requests here, because they require `build-multiarch-manifest` jobs, which have this condition that causes such jobs to be skipped on PR builds: https://github.com/rapidsai/docker/blob/1c27d9245fd9d99ee35981b970acaf10961ca45b/.github/workflows/build-test-publish-images.yml#L171-L172 This PR ensures that `test` jobs always run on PRs, and that merging is blocked until they succeed. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Ray Douglass (https://github.com/raydouglass) URL: #708
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #691
Proposes adding the
pr-builderworkflow, to ensure that all required checks have passed prior to merging (or auto-merging!) here.This makes auto-merger in this repo behave the way it does across most other repos (https://docs.rapids.ai/resources/auto-merger/).
In exchange, it means all changes will now require a full CI run to be merged. That can take 1-2 hours (list of recent runs).
Manual actions before merging
pr-builderworkflow does not succeed