Skip to content

Skip failing notebooks for 24.08#699

Merged
raydouglass merged 3 commits intorapidsai:branch-24.08from
jakirkham:skip_cuspatial_zipcodes_notebook
Aug 6, 2024
Merged

Skip failing notebooks for 24.08#699
raydouglass merged 3 commits intorapidsai:branch-24.08from
jakirkham:skip_cuspatial_zipcodes_notebook

Conversation

@jakirkham
Copy link
Copy Markdown
Member

@jakirkham jakirkham commented Aug 5, 2024

Currently branch-24.08 is failing on GHA because of cuSpatial's ZipCodes_Stops_PiP_cuSpatial.ipynb

These failures are already reported in these projects issues:

To help get 24.08 containers out, skip these notebook in the tests here

@jakirkham jakirkham requested a review from a team as a code owner August 5, 2024 21:24
@jakirkham jakirkham requested review from AyodeAwe, harrism, jameslamb and raydouglass and removed request for a team August 5, 2024 21:24
@bdice
Copy link
Copy Markdown
Contributor

bdice commented Aug 5, 2024

This also blocks CI on branch-24.10, see #696.

@jakirkham
Copy link
Copy Markdown
Member Author

A few jobs are seeing the same error we saw last week on CI

    RuntimeError: Download error (28) Timeout was reached [https://conda.anaconda.org/dask/label/dev/noarch/repodata.json.zst]
    Operation too slow. Less than 30 bytes/sec transferred the last 60 seconds

Think this is because so many nightlies have now accumulated in the dask channel and CDN is not used there

Fixing this will need some discussion with that community to find a reasonable course of action

For now will just restart as we currently require all GHA jobs to pass together (restarting failed jobs doesn't work here). More details on that in issue: https://github.com/rapidsai/ops/issues/3417

Comment thread context/test_notebooks.py
@raydouglass
Copy link
Copy Markdown
Contributor

raydouglass commented Aug 5, 2024

For now will just restart as we currently require all GHA jobs to pass together (restarting failed jobs doesn't work here). More details on that in issue: rapidsai/ops#3417

#702 is the WIP PR to fix this

@jakirkham jakirkham changed the title Skip cuSpatial's ZipCodes_Stops_PiP_cuSpatial.ipynb Skip failing notebooks for 24.08 Aug 5, 2024
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, hopefully we can trim back this list of ignored notebooks soon. These notebook tests have proven to be valuable (if expensive, in dev time) ways to catch bugs during this release cycle.

Comment thread context/test_notebooks.py Outdated
@raydouglass raydouglass merged commit 5cea518 into rapidsai:branch-24.08 Aug 6, 2024
@jakirkham jakirkham deleted the skip_cuspatial_zipcodes_notebook branch August 6, 2024 23:09
@jakirkham
Copy link
Copy Markdown
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants