-
Notifications
You must be signed in to change notification settings - Fork 55
remove reliance on rapidsai/ci-conda, use a versions.yaml #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d0756cb
remove reliance on rapidsai/ci-conda
jameslamb 71b9610
just use echo, gha-tools is unnecessary
jameslamb 3c02404
install yq and jq
jameslamb a378910
install newer yq, required for notebooks.sh
jameslamb 455c452
fine hadolint, fine
jameslamb 68114cc
notebooks image needs build args too
jameslamb 117df11
skip 'rapids' metapackage, just to test
jameslamb dcb9ac0
switch back to rapids metapackage
jameslamb 56494e7
use a versions.yaml
jameslamb be6d19d
Merge branch 'main' into no-ci-conda
jameslamb 8729973
Merge branch 'main' of github.com:rapidsai/docker into no-ci-conda
jameslamb 6a07d40
Merge branch 'no-ci-conda' of github.com:jameslamb/docker into no-ci-…
jameslamb af498f9
copyrights
jameslamb 252316f
fix workflow
jameslamb b4d6998
prefer 'notset' to 'unset', remove unnecessary MINIFORGE_VER, alphabe…
jameslamb d5797dd
match new renovate version
jameslamb a8cc963
bash array, not command evaluation
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,20 @@ | ||
| .vscode | ||
|
|
||
| *.a | ||
| *.bz2 | ||
| *.dll | ||
| *.dylib | ||
| *.exe | ||
| *.gz | ||
| *.png | ||
| .ruff_cache/ | ||
| *.so | ||
| *.tar.gz | ||
| *.tgz | ||
| *.whl | ||
| *.zip | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Saw |
||
|
|
||
| # Created by https://www.gitignore.io/api/macos,linux | ||
| ### Linux ### | ||
| *~ | ||
| .fuse_hidden* | ||
|
|
@@ -27,5 +40,3 @@ Icon | |
| Network Trash Folder | ||
| Temporary Items | ||
| .apdisk | ||
|
|
||
| # End of https://www.gitignore.io/api/macos,linux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| set -euo pipefail | ||
|
|
||
| # start with arguments provided by environment variables. Anything with a fallback is only used by | ||
| # a subset of images built here. | ||
| ARGS=" | ||
| CPU_ARCH: ${CPU_ARCH:-notset} | ||
| CUDA_VER: ${CUDA_VER} | ||
| LINUX_DISTRO: ${LINUX_DISTRO:-notset} | ||
| LINUX_DISTRO_VER: ${LINUX_DISTRO_VER:-notset} | ||
| LINUX_VER: ${LINUX_VER} | ||
| PYTHON_VER: ${PYTHON_VER} | ||
| RAPIDS_VER: ${RAPIDS_VER} | ||
| " | ||
| export ARGS | ||
|
|
||
| # add in arguments parsed out of 'versions.yaml' | ||
| if [ -n "${GITHUB_ACTIONS:-}" ]; then | ||
| # on GitHub Actions, create a step output called 'DOCKER_BUILD_ARGS' with this information appended to it. | ||
| # | ||
| # That can be referenced like: | ||
| # | ||
| # - name: Build image | ||
| # uses: docker/build-push-action@v6 | ||
| # with: | ||
| # build-args: | | ||
| # ${{ steps.generate-build-args.outputs.DOCKER_BUILD_ARGS }} | ||
| # | ||
| cat <<EOF > "${GITHUB_OUTPUT:-/dev/stdout}" | ||
| DOCKER_BUILD_ARGS<<EOT | ||
| $(yq -r '. + env(ARGS) | to_entries | map(.key + "=" + .value) | join(" \n")' versions.yaml) | ||
| EOT | ||
| EOF | ||
| else | ||
| yq -r '. + env(ARGS) | to_entries | map("--build-arg " + .key + "=" + .value) | join(" ")' versions.yaml | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just some string manipulation in bash +
jq+yq... I don't think we need to pay the cost of pulling a container image, and I think we can pretty safely just accept whateverjq/yqversion GitHub is shipping in its images (ref: https://github.com/actions/runner-images/tree/main/images/ubuntu).