Skip to content

install selector: Drop python 3.9 for nightlies, default to CUDA 12.5 for stable and nightly #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakirkham merged 4 commits into from
Aug 28, 2024
Merged

install selector: Drop python 3.9 for nightlies, default to CUDA 12.5 for stable and nightly #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c4db9f
drop Python 3.9 from install selector
jameslamb Aug 27, 2024
d093dbe
change default CUDA version to 12.5, allow for different Python versi…
jameslamb Aug 27, 2024
a088a12
drop CUDA 12.2
jameslamb Aug 27, 2024
e6073f3
handle switching Python version
jameslamb Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ docker run --rm \
--volume="$PWD:/srv/jekyll" \
--publish [::1]:4000:4000 \
jekyll/jekyll \
jekyll serve
bash -c 'rm -rf ./_site && jekyll serve'
Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following these testing steps as documented worked... but only the first time.

This command leaves behind a _site/ directory with file permissions showing the default user inside the container as the owner. Where that user differs from the default user on the system where you run docker run, the second attempt to run this fails like this:

chown: _site/assets/data: Permission denied
chown: _site/assets/data: Permission denied
chown: _site/assets: Permission denied
chown: _site/assets: Permission denied
chown: _site: Permission denied
chown: _site: Permission denied

Removing that directory at startup every time avoids that tiny bit of development friction.

```

## PR submissions
Expand Down
23 changes: 21 additions & 2 deletions _includes/selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@
active_python_ver: "3.11",
active_conda_cuda_ver: "12",
active_pip_cuda_ver: "12",
active_docker_cuda_ver: "12.2",
active_docker_cuda_ver: "12.5",
active_method: "Conda",
active_release: "Stable",
active_img_type: "Base",
Expand All @@ -380,9 +380,11 @@

// all possible values
python_vers: ["3.9", "3.10", "3.11"],
python_vers_stable: ["3.9", "3.10", "3.11"],
python_vers_nightly: ["3.10", "3.11"],
conda_cuda_vers: ["11", "12"],
pip_cuda_vers: ["11.4 - 11.8", "12"],
docker_cuda_vers: ["11.8", "12.0", "12.2", "12.5"],
docker_cuda_vers: ["11.8", "12.0", "12.5"],
Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12.5 images have been available since 24.08: rapidsai/docker#689

12.2 images will be dropped in 24.10: rapidsai/docker#696

Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm proposing just unconditionally dropping 12.2 for simplicity and to nudge people towards newer images.

But if reviewers disagree, I'd be happy to introduce a similar structure to what I'm proposing for Python versions, that allows the CUDA versions to differ by release. I think that'd be generically useful, just didn't add it here to limit the size of this PR.

methods: ["Conda", "pip", "Docker"],
releases: ["Stable", "Nightly"],
img_loc: ["NGC", "Dockerhub"],
Expand Down Expand Up @@ -708,6 +710,11 @@
},
disableUnsupportedPython(python_version) {
var isDisabled = false;
if (this.active_release === "Stable") {
isDisabled = !this.python_vers_stable.includes(python_version)
} else if (this.active_release === "Nightly") {
isDisabled = !this.python_vers_nightly.includes(python_version)
}
return isDisabled;
},
disableUnsupportedImgType(type) {
Expand All @@ -733,6 +740,18 @@
releaseClickHandler(e, release) {
if (this.isDisabled(e.target)) return;
this.active_release = release;

/*
It's possible that the active Python version prior to someone changing releases
isn't supported by whatever release was chosen in the selector.

This handles that case, updating to the oldest Python version supported by the chosen release.
*/
if (this.active_release === "Stable" && !this.python_vers_stable.includes(this.active_python_ver)) {
this.active_python_ver = this.python_vers_stable[0];
} else if (this.active_release === "Nightly" && !this.python_vers_nightly.includes(this.active_python_ver)) {
this.active_python_ver = this.python_vers_nightly[0];
}
},
imgTypeClickHandler(e, type) {
if (this.isDisabled(e.target)) return;
Expand Down
2 changes: 1 addition & 1 deletion install/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ ERROR: No matching distribution found for cudf-cu12
```
Check the suggestions below for possible resolutions:
- The pip index has moved from the initial experimental release! Ensure the correct `--extra-index-url=https://pypi.nvidia.com`
- Only Python versions 3.9, 3.10, and 3.11 are supported
- Only Python versions 3.10 and 3.11 are supported
- RAPIDS pip packages require a recent version of pip that [supports PEP600](https://peps.python.org/pep-0600/){: target="_blank"}. Some users may need to update pip: `pip install -U pip`

<br/>
Expand Down