post-processing: consolidate scripts, reduce use of global state#661
Merged
jameslamb merged 1 commit intorapidsai:mainfrom Aug 8, 2025
jameslamb:ci/local-state
Merged
post-processing: consolidate scripts, reduce use of global state#661jameslamb merged 1 commit intorapidsai:mainfrom jameslamb:ci/local-state
jameslamb merged 1 commit intorapidsai:mainfrom
jameslamb:ci/local-state
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
ajschmidt8
approved these changes
Aug 8, 2025
Member
ajschmidt8
left a comment
There was a problem hiding this comment.
you deserve a 🍪 for wrangling this mess.
Member
Author
|
Ha no prob, thanks for reviewing! I'll merge this so we can get some feedback from a deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#197 and https://github.com/rapidsai/ops/issues/4044
In #657 (and previously in #654), I'm working on adding an "Inactive Projects" section to https://docs.rapids.ai/api/, and currently struggling to make that work with the post-processing that populates drop-downs like this:
ref: https://docs.rapids.ai/api/cudf/stable/user_guide/
To try to make this more manageable to both change and review, this PR proposes some refactoring:
ci/customization/util.pyinto the only place they're used (to eliminate the indirection of an import)This should ONLY be a moving-code-around PR, it isn't intended to change anything about how the docs look or work.
Notes for Reviewers
I'm sorry, I know this has not been the most fun series of PRs to review. Thanks for your patience.
How I tested this
Using the steps added to the docs in #659
./ci/customization/customize_docs_in_folder.sh "_site/api/cudf"Beyond that, we'll have to merge this to find out if it worked.