Skip to content

Add support for Python 3.12, relax numcodecs pin#458

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.10from
jameslamb:python-3.12
Sep 4, 2024
Merged

Add support for Python 3.12, relax numcodecs pin#458
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.10from
jameslamb:python-3.12

Conversation

@jameslamb
Copy link
Copy Markdown
Member

Description

Contributes to rapidsai/build-planning#40

This PR adds support for Python 3.12.

Notes for Reviewers

This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.

A follow-up PR will revert back to pointing at the branch-24.10 branch of shared-workflows once all
RAPIDS repos have added Python 3.12 support.

This will fail until all dependencies have been updates to Python 3.12

CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.

This can be merged whenever all CI jobs are passing.

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 4, 2024
@jameslamb jameslamb changed the title Add support for Python 3.12 WIP: Add support for Python 3.12 Sep 4, 2024
Comment thread dependencies.yaml
- zarr
# See https://github.com/zarr-developers/numcodecs/pull/475
- numcodecs <0.12.0
- numcodecs !=0.12.0
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kvikio currently pins numcodecs<12.0

https://github.com/rapidsai/kvikio/blob/0e9ebcbc74b83302c8b73a8ac0b1ef6555919263/dependencies.yaml#L308-309

No version in that range published Python 3.12 builds on conda-forge.

- Encountered problems while solving:
-   - package numcodecs-0.10.0-py310hd8f1fbe_0 requires python_abi 3.10.* *_cp310, but none of the providers can be installed

(build link)

Looks like that pin was added in #300. The corresponding fix (zarr-developers/numcodecs#475) has been merged upstream and made it into numcodecs==0.12.1, so hopefully this pin can be relaxed now.

@jameslamb jameslamb changed the title WIP: Add support for Python 3.12 WIP: Add support for Python 3.12, relax numcodecs pin Sep 4, 2024
@jameslamb jameslamb changed the title WIP: Add support for Python 3.12, relax numcodecs pin Add support for Python 3.12, relax numcodecs pin Sep 4, 2024
@jameslamb jameslamb marked this pull request as ready for review September 4, 2024 21:22
@jameslamb jameslamb requested review from a team as code owners September 4, 2024 21:22
@jameslamb jameslamb requested review from AyodeAwe and bdice September 4, 2024 21:22
@bdice
Copy link
Copy Markdown
Contributor

bdice commented Sep 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3d48f2a into rapidsai:branch-24.10 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants