Fix the misplaced libcurl in CMake#587
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.02from Jan 14, 2025
Merged
Conversation
kingcrimsontianyu
added
bug
KyleFromNVIDIA
approved these changes
Jan 14, 2025
Contributor
Author
|
/merge |
bdice
approved these changes
Jan 14, 2025
abellina
approved these changes
Jan 14, 2025
abellina
left a comment
abellina
left a comment
There was a problem hiding this comment.
I built spark-rapids-jni with this change, and we are unblocked. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a CMake bug introduced in #581 where
libcurlis unconditionally compiled.