avoid packaging lib_treelite.{a,so}

[jameslamb]

libnvforest wheels are currently vendoring libtreelite.a and libtreelist_static.a. We don't need either... wheels are statically linking libtreelite

nvforest/python/libnvforest/CMakeLists.txt

Lines 40 to 42 in d8aa3ee

	# --- treelite --- #
	set(NVFOREST_PYTHON_TREELITE_TARGET treelite::treelite_static)
	set(NVFOREST_USE_TREELITE_STATIC ON)

This ensures those libraries are not packaged, cutting a few MB out of the final package size.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[jameslamb]

/ok to test

[jameslamb]

From the logs at https://github.com/rapidsai/nvforest/actions/runs/22780857190/job/66086276150?pr=77, looks like this is no longer getting packaged.

@hcho3 could you re-approve? (approvals on drafts don't count towards the codeowners requirement)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dba35040-5ad7-4953-aaa1-ffb724b6a85d

📥 Commits

Reviewing files that changed from the base of the PR and between d8aa3ee and c748d4d.

📒 Files selected for processing (1)

• cpp/cmake/thirdparty/get_treelite.cmake

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Optimized build configuration settings for improved Treelite dependency management.

Walkthrough

A CMake configuration variable name is updated in the Treelite integration file, changing the EXCLUDE_FROM_ALL parameter from ${NVFOREST} to ${NVFOREST_EXCLUDE_TREELITE_FROM_ALL} to more specifically control which targets are excluded from the build.

Changes

Cohort / File(s)	Summary
CMake Configuration cpp/cmake/thirdparty/get_treelite.cmake	Updated EXCLUDE_FROM_ALL parameter from ${NVFOREST} to ${NVFOREST_EXCLUDE_TREELITE_FROM_ALL} in the Treelite configuration block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'avoid packaging lib_treelite.{a,so}' directly describes the main change: preventing treelite libraries from being included in packaged wheels.
Description check	✅ Passed	The description explains the motivation (reducing wheel size) and context (static linking) for preventing treelite library packaging, clearly relating to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jameslamb]

/merge