Python bindings for Options.get()#303
Python bindings for Options.get()#303rapids-bot[bot] merged 11 commits intorapidsai:branch-25.06from
Options.get()#303Conversation
madsbk
added
breaking
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
Looks reasonable. I didn't follow the cython / template stuff completely, but that seems to have been at least partly moved from config.pyx so presumably it's OK :)
| which must be one of the supported Python types: bool, int, float, or str. | ||
| The `default_value` is cast to the corresponding C++ type before being passed | ||
| to the underlying options system. | ||
| The option is cast to the specified `return_type`, which must be one |
There was a problem hiding this comment.
This should probably be
| The option is cast to the specified `return_type`, which must be one | |
| The option is cast to the specified ``return_type``, which must be one |
I'm guessing this isn't included in our docs yet. Probably just need to add it to the index at https://github.com/rapidsai/rapidsmpf/blob/branch-25.06/docs/source/index.md?plain=1. LMK if you want to address that here & need help with it.
Likewise on L74 and L126 below.
There was a problem hiding this comment.
Let's do it in my next config PR, which will include a doc update
|
@rapidsai/rapidsmpf-cmake-codeowners, can I get one of you to review. The cmake changes a minor -- just adding new files to be compiled. |
|
/merge |
3 participants
Removing
Options.get_or_assign(), which is now replaced by the more genericOptions.get().