Open
Conversation
Signed-off-by: niranda perera <niranda.perera@gmail.com>
nirandaperera
added
improvement
madsbk
reviewed
Apr 17, 2026
| * | ||
| * @return A reference to the set of setup statistics prefixes. | ||
| */ | ||
| std::unordered_set<std::string> const& get_setup_stats_prefixes() const; |
Member
There was a problem hiding this comment.
Can we avoid the new prefix semantic and just let the user specify a mem_type? I think the current design is general enough to handle this without introducing a special setup_stats_prefixes_ handle?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables adding setup stats. Main usecase is to record pinned pool creation time. But we can add more stats later if needed