Skip to content

Add workflow to update latest and default branches#311

Merged
KyleFromNVIDIA merged 16 commits intobranch-25.04from
update-latest-branch
Mar 19, 2025
Merged

Add workflow to update latest and default branches#311
KyleFromNVIDIA merged 16 commits intobranch-25.04from
update-latest-branch

Conversation

@KyleFromNVIDIA
Copy link
Copy Markdown
Member

@KyleFromNVIDIA KyleFromNVIDIA commented Mar 18, 2025

Tested in rapidsai/cudf#18308.

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 18, 2025
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start. It seems the actual update step is still TODO?

From a policy perspective, here is the behavior I am expecting.

  • latest should point to the latest-available branch, like 25.06 right now (even though it is not yet the default branch)
  • default should point to the current default branch, like 25.04 right now

Most of the development cycle, latest and default will be the same. When burndown begins, latest will point to the newly created branch.

@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review March 19, 2025 17:24
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner March 19, 2025 17:24
Comment thread .github/workflows/update-latest-branch.yaml Outdated
Comment thread .github/workflows/update-latest-branch.yaml Outdated
Comment thread .github/workflows/update-latest-branch.yaml Outdated
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple suggestions but I am okay with the current state, if you disagree with my proposals or don't think they are worthwhile improvements. I'll approve this but am happy to take a second pass later.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

@bdice I've taken your feedback, removed an unnecessary API call, and added an all input to update all branches instead of just the one that got pushed. You can see the results here.

Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! This is really nice.

@KyleFromNVIDIA KyleFromNVIDIA merged commit 51e5d50 into branch-25.04 Mar 19, 2025
1 check passed
@bdice
Copy link
Copy Markdown
Contributor

bdice commented Mar 31, 2025

@KyleFromNVIDIA Following up on this -- is there an issue tracking how this will be rolled out / used in RAPIDS? I don't see one cross-linked here.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

KyleFromNVIDIA commented Apr 1, 2025

We decided to only run this workflow on shared-workflows itself. AFAIK, it's not needed anywhere else. I'll open a PR to start this.

Looks like I'd already opened #320.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

Oh, but we also realized that the token in the workflow won't have permission to push to protected branches, and we need an app or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants