make RAPIDS_AUX_SECRET_1 be an input variable secret name, not the secret itself#318
Merged
ajschmidt8 merged 2 commits intobranch-25.06from Apr 8, 2025
Merged
Conversation
gforsyth
approved these changes
Mar 19, 2025
Contributor
Author
|
/merge |
ajschmidt8
approved these changes
Apr 8, 2025
Member
ajschmidt8
left a comment
There was a problem hiding this comment.
since this is a breaking change, have all of the affected repositories been accounted for and updated accordingly?
Contributor
Author
|
Yes they have. The only use is in an inactive private repo that has an open PR to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the
RAPIDS_AUX_SECRET_1value to an input of a secret name, then defines theRAPIDS_AUX_SECRET_1envvar from thesecretscontext to align with the way we're passing in other secrets.Without this change, it isn't possible for a calling workflow to define both
inputs.extra-repo-deploy-keyandsecrets.RAPIDS_AUX_SECRET_1-- the caller has to choose either:{ secrets: inherit, with: { extra-repo-deploy-key: 'KEY_NAME' } }, or{ secrets: { RAPIDS_AUX_SECRET_1: ${{ secrets.SECRET }} } }In the second case, the shared workflow's
secretscontext only containsRAPIDS_AUX_SECRET_1, notKEY_NAME, because we had to pass it instead ofsecrets: inherit.