Skip to content

make RAPIDS_AUX_SECRET_1 be an input variable secret name, not the secret itself#318

Merged
ajschmidt8 merged 2 commits intobranch-25.06from
rapids-aux-secret-input
Apr 8, 2025
Merged

make RAPIDS_AUX_SECRET_1 be an input variable secret name, not the secret itself#318
ajschmidt8 merged 2 commits intobranch-25.06from
rapids-aux-secret-input

Conversation

@trxcllnt
Copy link
Copy Markdown
Contributor

Switches the RAPIDS_AUX_SECRET_1 value to an input of a secret name, then defines the RAPIDS_AUX_SECRET_1 envvar from the secrets context to align with the way we're passing in other secrets.

Without this change, it isn't possible for a calling workflow to define both inputs.extra-repo-deploy-key and secrets.RAPIDS_AUX_SECRET_1 -- the caller has to choose either:

  1. { secrets: inherit, with: { extra-repo-deploy-key: 'KEY_NAME' } }, or
  2. { secrets: { RAPIDS_AUX_SECRET_1: ${{ secrets.SECRET }} } }

In the second case, the shared workflow's secrets context only contains RAPIDS_AUX_SECRET_1, not KEY_NAME, because we had to pass it instead of secrets: inherit.

@trxcllnt trxcllnt requested a review from a team as a code owner March 19, 2025 18:31
@trxcllnt trxcllnt requested a review from gforsyth March 19, 2025 18:31
@trxcllnt trxcllnt added improvement Improves an existing functionality breaking Introduces a breaking change labels Mar 19, 2025
@trxcllnt trxcllnt changed the base branch from branch-25.04 to branch-25.06 April 8, 2025 19:52
@trxcllnt
Copy link
Copy Markdown
Contributor Author

trxcllnt commented Apr 8, 2025

/merge

Copy link
Copy Markdown
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a breaking change, have all of the affected repositories been accounted for and updated accordingly?

@trxcllnt
Copy link
Copy Markdown
Contributor Author

trxcllnt commented Apr 8, 2025

Yes they have. The only use is in an inactive private repo that has an open PR to update.

@ajschmidt8 ajschmidt8 merged commit a315db2 into branch-25.06 Apr 8, 2025
1 check passed
@ajschmidt8 ajschmidt8 deleted the rapids-aux-secret-input branch April 8, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants