Skip to content

Remove deprecated wheel-name variable and make inputs required #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jayavenkatesh19 wants to merge 2 commits into from
Closed

Remove deprecated wheel-name variable and make inputs required #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44384b6
remove wheel-name variable in wheel-builds
jayavenkatesh19 May 2, 2025
99ae1a6
changed package-name and package-type variables from optional to requ…
jayavenkatesh19 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .github/workflows/wheels-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,13 @@ on:
required: true
type: string
package-name:
required: false
required: true
type: string
description: "Distribution name, without any other qualifiers (e.g. 'pylibcudf', not 'pylibcudf-cu12-cp311-manylinux_2_24_aarch64')"
package-type:
description: "One of: [cpp, python]"
required: false
type: string
wheel-name:
required: false
required: true
type: string
description: "DEPRECATED: Use package-name instead"
pure-wheel:
required: false
type: boolean
Expand Down Expand Up @@ -200,10 +196,9 @@ jobs:
shell: bash -leo pipefail {0}

- name: Get package name
if: inputs.package-type != ''
env:
PACKAGE_TYPE: ${{ inputs.package-type }}
WHEEL_NAME: ${{ inputs.package-name != '' && inputs.package-name || inputs.wheel-name }}
WHEEL_NAME: ${{ inputs.package-name }}
PURE_WHEEL: ${{ inputs.pure-wheel }}
APPEND_CUDA_SUFFIX: ${{ inputs.append-cuda-suffix }}
run: |
Expand All @@ -224,13 +219,11 @@ jobs:
id: package-name

- name: Show files to be uploaded
if: inputs.package-type != ''
run: |
echo "Contents of directory to be uploaded:"
ls -R ${{ steps.package-name.outputs.WHEEL_OUTPUT_DIR }}

- uses: actions/upload-artifact@v4
if: inputs.package-type != ''
with:
name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.WHEEL_OUTPUT_DIR }}
Expand Down