conda-cpp-post-build-checks: switch to always running by default, add docs#382
Merged
jameslamb merged 2 commits intobranch-25.08from Jun 25, 2025
Merged
conda-cpp-post-build-checks: switch to always running by default, add docs#382jameslamb merged 2 commits intobranch-25.08from
jameslamb merged 2 commits intobranch-25.08from
Conversation
jameslamb
added
improvement
jameslamb
commented
Jun 24, 2025
| Regular expression matching unmangled symbol names to be ignored by this check. | ||
| Should be wrapped in '()' to form a capture group. | ||
| For example, to ignore any function symbols coming from the 'thrust' or 'cub' namespaces, | ||
| you might provide '(void (thrust::|cub::))'. |
Member
Author
There was a problem hiding this comment.
References that led me to think this is how it's working:
bdice
approved these changes
Jun 24, 2025
This was referenced Jun 26, 2025
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jul 1, 2025
Contributes to rapidsai/shared-workflows#376 * adds descriptions for all inputs to workflows triggered by `workflow_dispatch` Contributes to rapidsai/shared-workflows#379 * removes input `enable_check_symbols` for `conda-cpp-checks` workflow... no longer needed as of rapidsai/shared-workflows#382 ## Notes for Reviewers ### Motivation The input descriptions show up in the UI when you go to trigger these workflows. Like this:  I'm hoping that will make it easier for developers to manually trigger workflows. Inspired by being asked multiple times "what format is `date` supposed to be in?". Removing `enable_check_symbols` here is a step towards completely removing that always-true input, as part of rapidsai/shared-workflows#379 ### Other repos? This is the first of these PRs... let's use it to decide on phrasing that we like. Once it's approved and merged, I'll open similar PRs across RAPIDS. # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #19234
This was referenced Jul 1, 2025
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Jul 1, 2025
Contributes to rapidsai/shared-workflows#376 * adds descriptions for all inputs to workflows triggered by `workflow_dispatch` Contributes to rapidsai/shared-workflows#379 * removes input `enable_check_symbols` for `conda-cpp-checks` workflow... no longer needed as of rapidsai/shared-workflows#382 ## Notes for Reviewers ### Motivation The input descriptions show up in the UI when you go to trigger these workflows. Like this:  I'm hoping that will make it easier for developers to manually trigger workflows. Inspired by being asked multiple times "what format is `date` supposed to be in?". Removing `enable_check_symbols` here is a step towards completely removing that always-true input, as part of rapidsai/shared-workflows#379 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #2728
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jul 1, 2025
Contributes to rapidsai/shared-workflows#376 * adds descriptions for all inputs to workflows triggered by `workflow_dispatch` Contributes to rapidsai/shared-workflows#379 * removes input `enable_check_symbols` for `conda-cpp-checks` workflow... no longer needed as of rapidsai/shared-workflows#382 ## Notes for Reviewers ### Motivation The input descriptions show up in the UI when you go to trigger these workflows. Like this:  I'm hoping that will make it easier for developers to manually trigger workflows. Inspired by being asked multiple times "what format is `date` supposed to be in?". Removing `enable_check_symbols` here is a step towards completely removing that always-true input, as part of rapidsai/shared-workflows#379 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #6952
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jul 1, 2025
Contributes to rapidsai/shared-workflows#376 * adds descriptions for all inputs to workflows triggered by `workflow_dispatch` Contributes to rapidsai/shared-workflows#379 * removes input `enable_check_symbols` for `conda-cpp-checks` workflow... no longer needed as of rapidsai/shared-workflows#382 ## Notes for Reviewers ### Motivation The input descriptions show up in the UI when you go to trigger these workflows. Like this:  I'm hoping that will make it easier for developers to manually trigger workflows. Inspired by being asked multiple times "what format is `date` supposed to be in?". Removing `enable_check_symbols` here is a step towards completely removing that always-true input, as part of rapidsai/shared-workflows#379 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #5139
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Jul 1, 2025
Contributes to rapidsai/shared-workflows#376 * adds descriptions for all inputs to workflows triggered by `workflow_dispatch` Contributes to rapidsai/shared-workflows#379 * removes input `enable_check_symbols` for `conda-cpp-checks` workflow... no longer needed as of rapidsai/shared-workflows#382 ## Notes for Reviewers ### Motivation The input descriptions show up in the UI when you go to trigger these workflows. Like this:  I'm hoping that will make it easier for developers to manually trigger workflows. Inspired by being asked multiple times "what format is `date` supposed to be in?". Removing `enable_check_symbols` here is a step towards completely removing that always-true input, as part of rapidsai/shared-workflows#379 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1075
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #376
Contributes to #379
Some small changes to
conda-cpp-post-build-checks:symbol_exclusionsinputenable_check_symbolstotruecheck_symbolsinput #379 ... all repos calling this are already directly passingtrue. This is a step towards completely removing that input.