Skip to content

GH-78: [Test] Update merge_arrow_pr.py tyer #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raulcd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-78: [Test] Update merge_arrow_pr.py tyer #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7abb1
GH-35943: [Dev] Ensure link issue works when PR body is empty (#80)
raulcd Jul 4, 2023
5e2e832
Update merge_arrow_pr.py
raulcd Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dev_pr/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ async function commentGitHubURL(github, context, pullRequestNumber, issueID) {
const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
const message = "* Closes: #" + issueInfo.number
if (issueInfo) {
if (context.payload.pull_request.body.includes(message)) {
if (context.payload.pull_request.body != null && context.payload.pull_request.body.includes(message)) {
return;
}
await github.rest.pulls.update({
Expand Down
1 change: 1 addition & 0 deletions dev/merge_arrow_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
os.environ.get("PR_REMOTE_NAME") or # backward compatibility
"apache"
)
# test
PROJECT_NAME = os.environ.get('ARROW_PROJECT_NAME') or "arrow"

# For testing to avoid accidentally pushing to apache
Expand Down