Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 130 additions & 36 deletions .php_cs
Original file line number Diff line number Diff line change
@@ -1,38 +1,132 @@
<?php
$finder = Symfony\CS\Finder\DefaultFinder::create()
->in(__DIR__);

$config = Symfony\CS\Config\Config::create()
->level(Symfony\CS\FixerInterface::PSR2_LEVEL)
->finder($finder)
->fixers(
[
'extra_empty_lines',
'no_blank_lines_after_class_opening',
'no_empty_lines_after_phpdocs',
'operators_spaces',
'duplicate_semicolon',
'namespace_no_leading_whitespace',
'phpdoc_indent',
'phpdoc_no_empty_return',
'phpdoc_no_package',
'phpdoc_params',
'phpdoc_separation',
'phpdoc_to_comment',
'phpdoc_trim',
'phpdoc_var_without_name',
'remove_leading_slash_use',
'remove_lines_between_uses',
'return',
'single_array_no_trailing_comma',
'single_quote',
'spaces_before_semicolon',
'spaces_cast',
'standardize_not_equal',
'ternary_spaces',
'whitespacy_lines',
'ordered_use',
'short_array_syntax'
]
);
return $config;
$header = <<<'EOF'
This file is part of the Ray.WebFormModule package.

@license http://opensource.org/licenses/MIT MIT
EOF;

return \PhpCsFixer\Config::create()
->setRiskyAllowed(true)
->setRules(array(
'@PSR2' => true,
'header_comment' => ['header' => $header, 'commentType' => 'PHPDoc', 'separate' => 'none'],
'array_syntax' => ['syntax' => 'short'],
'binary_operator_spaces' => ['align_equals' => false, 'align_double_arrow' => false],
'blank_line_after_opening_tag' => true,
'blank_line_after_namespace' => false,
'blank_line_before_return' => true,
'cast_spaces' => true,
// 'class_keyword_remove' => true,
'combine_consecutive_unsets' => true,
'concat_space' => ['spacing' => 'one'],
'declare_equal_normalize' => true,
'declare_strict_types' => false,
'dir_constant' => true,
'ereg_to_preg' => true,
'function_typehint_space' => true,
'general_phpdoc_annotation_remove' => true,
'hash_to_slash_comment' => true,
'heredoc_to_nowdoc' => true,
'include' => true,
'indentation_type' => true,
'is_null' => ['use_yoda_style' => false],
'linebreak_after_opening_tag' => true,
'lowercase_cast' => true,
// 'mb_str_functions' => true,
'method_separation' => true,
'modernize_types_casting' => true,
'native_function_casing' => true,
// 'native_function_invocation' => true,
'new_with_braces' => false, //
'no_alias_functions' => true,
'no_blank_lines_after_class_opening' => true,
'no_blank_lines_after_phpdoc' => true,
'no_blank_lines_before_namespace' => true,
'no_empty_comment' => true,
'no_empty_phpdoc' => true,
'no_empty_statement' => true,
'no_extra_consecutive_blank_lines' => ['break', 'continue', 'curly_brace_block', 'extra', 'parenthesis_brace_block', 'return', 'square_brace_block', 'throw', 'use', 'useTrait'],
'no_leading_import_slash' => true,
'no_leading_namespace_whitespace' => true,
'no_mixed_echo_print' => ['use' => 'echo'],
'no_multiline_whitespace_around_double_arrow' => true,
'no_multiline_whitespace_before_semicolons' => true,
'no_php4_constructor' => false,
'no_short_bool_cast' => true,
'no_short_echo_tag' => false,
'no_singleline_whitespace_before_semicolons' => true,
'no_spaces_around_offset' => true,
'no_trailing_comma_in_list_call' => true,
'no_trailing_comma_in_singleline_array' => true,
'no_trailing_whitespace' => true,
'no_trailing_whitespace_in_comment' => true,
'no_unneeded_control_parentheses' => true,
'no_unreachable_default_argument_value' => true,
'no_unused_imports' => true,
'no_useless_else' => true,
'no_useless_return' => true,
'no_whitespace_before_comma_in_array' => true,
'no_whitespace_in_blank_line' => true,
'normalize_index_brace' => true,
'not_operator_with_space' => false,
'not_operator_with_successor_space' => true,
'object_operator_without_whitespace' => true,
'ordered_class_elements' => true,
'ordered_imports' => true,
'php_unit_construct' => true,
'php_unit_dedicate_assert' => true,
'php_unit_fqcn_annotation' => true,
'php_unit_strict' => true,
// 'phpdoc_add_missing_param_annotation' => true,
'phpdoc_align' => true,
'phpdoc_annotation_without_dot' => true,
'phpdoc_indent' => true,
'phpdoc_inline_tag' => true,
'phpdoc_no_access' => true,
'phpdoc_no_alias_tag' => ['property-read' => 'property', 'property-write' => 'property', 'type' => 'var'],
'phpdoc_no_empty_return' => true,
'phpdoc_no_package' => true,
// 'phpdoc_no_useless_inheritdoc' => true,
'phpdoc_order' => true,
'phpdoc_return_self_reference' => true,
'phpdoc_scalar' => true,
'phpdoc_separation' => true,
'phpdoc_single_line_var_spacing' => true,
// 'phpdoc_summary' => true,
'phpdoc_to_comment' => true,
'phpdoc_trim' => true,
'phpdoc_types' => true,
'phpdoc_var_without_name' => true,
'pow_to_exponentiation' => true,
// 'pre_increment' => true,
'protected_to_private' => true,
'psr0' => true,
'psr4' => true,
'random_api_migration' => true,
'return_type_declaration' => ['space_before' => 'one'],
'self_accessor' => true,
'short_scalar_cast' => true,
// 'silenced_deprecation_error' => true,
// 'simplified_null_return' => true,
// 'single_blank_line_before_namespace' => true,
'single_quote' => true,
'space_after_semicolon' => true,
'standardize_not_equals' => true,
// 'strict_comparison' => true,
'ternary_operator_spaces' => true,
'strict_param' => true,
// 'ternary_to_null_coalescing' => true,
// 'trailing_comma_in_multiline_array' => true,
'trim_array_spaces' => true,
'unary_operator_spaces' => true,
'whitespace_after_comma_in_array' => true
))
->setFinder(
PhpCsFixer\Finder::create()
->exclude('tests/Fake')
->exclude('src-data')
->exclude('src-deprecated')
->in(__DIR__)
)->setLineEnding("\n")
->setUsingCache(false);
27 changes: 17 additions & 10 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,24 @@
language: php

sudo: false
php:
- 5.5
- 5.6
- hhvm
- 7

install: travis_retry composer install --no-interaction --prefer-source

- 7.1
- hhvm
cache:
directories:
- vendor
- $HOME/.composer/cache
env:
matrix:
- DEPENDENCIES=""
- DEPENDENCIES="--prefer-lowest --prefer-stable"
before_script:
- composer self-update
- composer update $DEPENDENCIES
script:
- if [ "$TRAVIS_PHP_VERSION" == "hhvm" ]; then phpunit; fi
- if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then phpunit --coverage-text --coverage-clover=coverage.clover; fi
- ./vendor/bin/phpunit --coverage-clover=coverage.clover;
- if [ "$TRAVIS_PHP_VERSION" = "7.1" ]; then wget http://cs.sensiolabs.org/download/php-cs-fixer-v2.phar && php php-cs-fixer-v2.phar fix --config=.php_cs -v --dry-run --using-cache=no --path-mode=intersection `git diff --name-only --diff-filter=ACMRTUXB $TRAVIS_COMMIT_RANGE`; fi

after_script:
- wget https://scrutinizer-ci.com/ocular.phar
- if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then php ocular.phar code-coverage:upload --format=php-clover coverage.clover; fi
- if [ "$TRAVIS_PHP_VERSION" = "7.1" ]; then wget https://scrutinizer-ci.com/ocular.phar && php ocular.phar code-coverage:upload --format=php-clover coverage.clover; fi
20 changes: 14 additions & 6 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@
"Ray.Di module"
],
"require": {
"ray/di": "^2.0",
"foa/filter-input-bundle": "^1.1@dev",
"aura/filter": "^2.0@dev",
"ray/di": "^2.5",
"aura/input": "^1.2",
"aura/filter": "^2.3",
"aura/html": "^2.4",
"ray/aura-session-module": "~1.0"
"ray/aura-session-module": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^5.7.13"
},
"license": "MIT",
"autoload":{
Expand All @@ -20,8 +23,13 @@
},
"autoload-dev":{
"psr-4":{
"Ray\\WebFormModule\\": "tests/",
"Ray\\WebFormModule\\": "tests/Fake"
"Ray\\WebFormModule\\": ["tests/", "tests/Fake"]
}
},
"scripts" :{
"test": ["@cs", "phpunit"],
"coverage": ["php -dzend_extension=xdebug.so ./vendor/bin/phpunit --coverage-text --coverage-html=build/coverage"],
"cs": ["php-cs-fixer fix -v --dry-run", "phpcs --standard=./phpcs.xml src"],
"cs-fix": ["php-cs-fixer fix -v", "phpcbf src"]
}
}
64 changes: 34 additions & 30 deletions docs/demo/1.csrf/ContactForm.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php

/**
* This file is part of the Ray.WebFormModule package.
*
* @license http://opensource.org/licenses/MIT MIT
*/
namespace Ray\WebFormModule;

use Aura\Input\Filter;
Expand All @@ -8,6 +12,35 @@ class ContactForm extends AbstractAuraForm
{
use SetAntiCsrfTrait;

/**
* {@inheritdoc}
*/
public function __toString()
{
$form = $this->form();
// name
$form .= $this->helper->tag('div', ['class' => 'form-group']);
$form .= $this->helper->tag('label', ['for' => 'name']);
$form .= 'Name:';
$form .= $this->helper->tag('/label') . PHP_EOL;
$form .= $this->input('name');
$form .= $this->error('name');
$form .= $this->helper->tag('/div') . PHP_EOL;
// message
$form .= $this->helper->tag('div', ['class' => 'form-group']);
$form .= $this->helper->tag('label', ['for' => 'message']);
$form .= 'Message:';
$form .= $this->helper->tag('/label') . PHP_EOL;
$form .= $this->input('message');
$form .= $this->error('message');
$form .= $this->helper->tag('/div') . PHP_EOL;
// submit
$form .= $this->input('submit');
$form .= $this->helper->tag('/form');

return $form;
}

/**
* {@inheritdoc}
*/
Expand Down Expand Up @@ -60,33 +93,4 @@ public function submit()
{
return $_POST;
}

/**
* {@inheritdoc}
*/
public function __toString()
{
$form = $this->form();
// name
$form .= $this->helper->tag('div', ['class' => 'form-group']);
$form .= $this->helper->tag('label', ['for' => 'name']);
$form .= 'Name:';
$form .= $this->helper->tag('/label') . PHP_EOL;
$form .= $this->input('name');
$form .= $this->error('name');
$form .= $this->helper->tag('/div') . PHP_EOL;
// message
$form .= $this->helper->tag('div', ['class' => 'form-group']);
$form .= $this->helper->tag('label', ['for' => 'message']);
$form .= 'Message:';
$form .= $this->helper->tag('/label') . PHP_EOL;
$form .= $this->input('message');
$form .= $this->error('message');
$form .= $this->helper->tag('/div') . PHP_EOL;
// submit
$form .= $this->input('submit');
$form .= $this->helper->tag('/form');

return $form;
}
}
6 changes: 5 additions & 1 deletion docs/demo/1.csrf/Controller.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php

/**
* This file is part of the Ray.WebFormModule package.
*
* @license http://opensource.org/licenses/MIT MIT
*/
namespace Ray\WebFormModule;

use Ray\Di\Di\Inject;
Expand Down
6 changes: 5 additions & 1 deletion docs/demo/1.csrf/MyModule.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php

/**
* This file is part of the Ray.WebFormModule package.
*
* @license http://opensource.org/licenses/MIT MIT
*/
namespace Ray\WebFormModule;

use Ray\Di\AbstractModule;
Expand Down
9 changes: 6 additions & 3 deletions docs/demo/1.csrf/run.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<?php

/* @var $loader \Composer\Autoload\ClassLoader */
/**
* This file is part of the Ray.WebFormModule package.
*
* @license http://opensource.org/licenses/MIT MIT
*/
$loader = require dirname(__DIR__) . '/autoload.php';
$loader->addPsr4('Ray\WebFormModule\\', __DIR__);
use Aura\Input\Exception\CsrfViolation;
Expand All @@ -14,7 +17,7 @@
try {
$controller->createUser(['name' => 'bear', 'message' => 'hello']);
} catch (CsrfViolation $e) {
echo 'Anti CSRF works !'. PHP_EOL;
echo 'Anti CSRF works !' . PHP_EOL;
exit;
}
echo 'Anti CSRF DOES NOT works !' . PHP_EOL;
Expand Down
6 changes: 5 additions & 1 deletion docs/demo/1.csrf/web.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php

/**
* This file is part of the Ray.WebFormModule package.
*
* @license http://opensource.org/licenses/MIT MIT
*/
use Ray\Di\Injector;
use Ray\WebFormModule\Controller;
use Ray\WebFormModule\MyModule;
Expand Down
5 changes: 5 additions & 0 deletions docs/demo/autoload.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
<?php
/**
* This file is part of the Ray.WebFormModule package.
*
* @license http://opensource.org/licenses/MIT MIT
*/
use Doctrine\Common\Annotations\AnnotationRegistry;

$autoloader = dirname(dirname(__DIR__)) . '/vendor/autoload.php';
Expand Down
1 change: 1 addition & 0 deletions phpcs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<rule ref="PSR2">
<exclude name="Generic.Files.LineLength"/>
</rule>
<rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
<rule ref="PEAR.Commenting.FunctionComment">
<exclude name="PEAR.Commenting.FunctionComment.MissingReturn"/>
<exclude name="PEAR.Commenting.FunctionComment.MissingParamComment"/>
Expand Down
Loading