Skip to content

Revert "[Dashboard] Start the new dashboard (#9860)"#10116

Merged
rkooo567 merged 1 commit intoray-project:masterfrom
robertnishihara:revert
Aug 14, 2020
Merged

Revert "[Dashboard] Start the new dashboard (#9860)"#10116
rkooo567 merged 1 commit intoray-project:masterfrom
robertnishihara:revert

Conversation

@robertnishihara
Copy link
Collaborator

This reverts commit 739933e.

#9860 broke Windows.

@robertnishihara
Copy link
Collaborator Author

cc @raulchen @fyrestone

Copy link
Contributor

@mfitton mfitton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved revert, pull breaks windows build.

@rkooo567
Copy link
Contributor

@fyrestone Please feel free to reopen the PR. I will also send a slack message. The issue here was that our Windows build failed due to this change. Please create a new PR that addresses that issue!

The error was previously

bazel-out/x64_windows-opt/bin/_virtual_includes/raylet_lib\ray/raylet/agent_manager.h(51): error C3646: 'agent_pid_': unknown override specifier
383
bazel-out/x64_windows-opt/bin/_virtual_includes/raylet_lib\ray/raylet/agent_manager.h(51): error C2059: syntax error: '='
384
bazel-out/x64_windows-opt/bin/_virtual_includes/raylet_lib\ray/raylet/agent_manager.h(51): error C2238: unexpected token(s) preceding ';'

@rkooo567 rkooo567 merged commit 36e626e into ray-project:master Aug 14, 2020
@fyrestone
Copy link
Contributor

fyrestone commented Aug 15, 2020

@fyrestone Please feel free to reopen the PR. I will also send a slack message. The issue here was that our Windows build failed due to this change. Please create a new PR that addresses that issue!

The error was previously

bazel-out/x64_windows-opt/bin/_virtual_includes/raylet_lib\ray/raylet/agent_manager.h(51): error C3646: 'agent_pid_': unknown override specifier
383
bazel-out/x64_windows-opt/bin/_virtual_includes/raylet_lib\ray/raylet/agent_manager.h(51): error C2059: syntax error: '='
384
bazel-out/x64_windows-opt/bin/_virtual_includes/raylet_lib\ray/raylet/agent_manager.h(51): error C2238: unexpected token(s) preceding ';'

Sorry for the break. I will fix this problem. I should include the process.h in agent_manager.h, there is a typedef int pid_t; in process.h.

@fyrestone
Copy link
Contributor

Please feel free to review the PR: #10131

@fyrestone
Copy link
Contributor

I noticed that the windows-msvc windows-msvc is always RED, why you guys merged these PRs to master?

@rkooo567
Copy link
Contributor

.Window-msvc is always red because of test failures, but your original PR broke the build itself (so it couldn’t even start)

@robertnishihara
Copy link
Collaborator Author

@fyrestone @rkooo567 the "always red" state is a big problem (which is why PRs like this get merged accidentally). I'll try to fix that this weekend.

@robertnishihara robertnishihara deleted the revert branch August 15, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants