[Java] Add fetchLocal parameter in Ray.wait()#13604
Merged
kfstorm merged 4 commits intoray-project:masterfrom Jan 22, 2021
Merged
[Java] Add fetchLocal parameter in Ray.wait()#13604kfstorm merged 4 commits intoray-project:masterfrom
fetchLocal parameter in Ray.wait()#13604kfstorm merged 4 commits intoray-project:masterfrom
Conversation
Contributor
|
Looks like there might be travis errors. |
stephanie-wang
added
the
@author-action-required
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#12526 introduced
fetch_localforray.wait(), but it forgot to update Java API and the JNI function signature ofnativeWaitdoesn't match the one in Java code. So thefetch_localvalue of JNI functionnativeWaitis undefined.To prevent this kind of issue in future, I also added a check in
java/test.shto make sure that the generated JNI header files match the native method definitions in Java.Related issue number
Checks
scripts/format.shto lint the changes in this PR.