Skip to content

[tune] update Optuna integration to 2.4.0 API#13631

Merged
richardliaw merged 3 commits intoray-project:masterfrom
krfricke:tune-fix-optuna
Jan 23, 2021
Merged

[tune] update Optuna integration to 2.4.0 API#13631
richardliaw merged 3 commits intoray-project:masterfrom
krfricke:tune-fix-optuna

Conversation

@krfricke
Copy link
Contributor

Why are these changes needed?

Optuna break after updating to 2.4.0 - this adapts to the new API.

Related issue number

Closes #13622

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krfricke
Copy link
Contributor Author

The failing tests seem unrelated to this PR. I'm rerunning them anyway and will check tomorrow.

@richardliaw richardliaw merged commit 17760e1 into ray-project:master Jan 23, 2021
@krfricke krfricke deleted the tune-fix-optuna branch January 23, 2021 11:55
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Co-authored-by: Amog Kamsetty <amogkamsetty@yahoo.com>
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tune] AttributeError: 'InMemoryStorage' object has no attribute 'set_trial_value' - Optuna

3 participants