Skip to content

[RLlib] Add grad_clip config option to MARWIL and stabilize grad clipping against inf global_norms.#13634

Merged
sven1977 merged 1 commit intoray-project:masterfrom
sven1977:add_grad_clip_to_marwil
Jan 22, 2021
Merged

[RLlib] Add grad_clip config option to MARWIL and stabilize grad clipping against inf global_norms.#13634
sven1977 merged 1 commit intoray-project:masterfrom
sven1977:add_grad_clip_to_marwil

Conversation

@sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 22, 2021

Add grad_clip config option to MARWIL and stabilize grad clipping against inf global_norms.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 merged commit d629292 into ray-project:master Jan 22, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
…rad clipping against inf global_norms. (ray-project#13634)"

This reverts commit cf04362.
@sven1977 sven1977 deleted the add_grad_clip_to_marwil branch March 27, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants