[xray] Fix UniqueID hashing for object and task IDs.#2017
Merged
stephanie-wang merged 2 commits intoray-project:masterfrom May 11, 2018
Merged
[xray] Fix UniqueID hashing for object and task IDs.#2017stephanie-wang merged 2 commits intoray-project:masterfrom
stephanie-wang merged 2 commits intoray-project:masterfrom
Conversation
|
Test PASSed. |
Contributor
|
@stephanie-wang Can you fix the linting error? |
|
Test PASSed. |
alok
added a commit
to alok/ray
that referenced
this pull request
May 11, 2018
* master: [xray] Fix UniqueID hashing for object and task IDs. (ray-project#2017) [DataFrame] Fixing bugs in groupby (ray-project#2031) [DataFrame] Fixes dropna subset bug (ray-project#2018)
alok
added a commit
to alok/ray
that referenced
this pull request
May 11, 2018
* master: [xray] Fix UniqueID hashing for object and task IDs. (ray-project#2017) [DataFrame] Fixing bugs in groupby (ray-project#2031) [DataFrame] Fixes dropna subset bug (ray-project#2018) [DataFrame] Implement where (ray-project#1989)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
ObjectIDs in xray share the same suffix as the ID of the task that created the objects. The prefix is the index of the object creation (0 for the task, <0 for objects created byray.put, >0 for returned objects). Therefore, hashing on the prefix bytes will cause more collisions than expected. This PR skips the prefix for theUniqueIDhash function.