[Core][nightly-test] better way of calculating num features#22158
Merged
scv119 merged 3 commits intoray-project:masterfrom Feb 7, 2022
Merged
[Core][nightly-test] better way of calculating num features#22158scv119 merged 3 commits intoray-project:masterfrom
scv119 merged 3 commits intoray-project:masterfrom
Conversation
matthewdeng
approved these changes
Feb 7, 2022
rkooo567
approved these changes
Feb 7, 2022
scv119
added
the
tests-ok
2 tasks
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
…ect#22158) * better filter of column length * address comments * more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
previously, we use num_columns - 2 to calculate the feature size where we assumes both the "label" and arrow internal column
__index_level_0__exists in the schema.however, the
__index_level_0__might not exist in the dataset's schema, which causes this check fail.in this pr, we use a better way to filter out arrow internal column and label column.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.