[Dashboard] avoid showing disk info when it is unavailable#24992
Merged
simon-mo merged 1 commit intoray-project:masterfrom May 25, 2022
Merged
[Dashboard] avoid showing disk info when it is unavailable#24992simon-mo merged 1 commit intoray-project:masterfrom
simon-mo merged 1 commit intoray-project:masterfrom
Conversation
mwtian
changed the title
Member
Author
|
Gentle ping @alanwguo ? |
alanwguo
approved these changes
May 24, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I have encountered failures in dashboard page because there was no disk info for a node. So add a check to ensure disk info is available.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.