Skip to content

[RLLib ] Better default parameters with training intensity for R2D2#25510

Merged
sven1977 merged 2 commits intoray-project:masterfrom
ArturNiederfahrenhorst:r2d2fix
Jun 7, 2022
Merged

[RLLib ] Better default parameters with training intensity for R2D2#25510
sven1977 merged 2 commits intoray-project:masterfrom
ArturNiederfahrenhorst:r2d2fix

Conversation

@ArturNiederfahrenhorst
Copy link
Contributor

Why are these changes needed?

This PR deflakes R2D2 learning regression tests.
Since I introduced training intesity to R2D2 in #24923, the relevant parameters had not been tuned.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLLib ] Better default parameters with training intensity [RLLib ] Better default parameters with training intensity for R2D2 Jun 6, 2022
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this all looks fine to me, but can you clarify:

what are the "necessary parameters that you needed to turn on"?
It doesn't look like you turned on any parameters in this PR.

@ArturNiederfahrenhorst
Copy link
Contributor Author

ArturNiederfahrenhorst commented Jun 6, 2022

There are no "necessary parameters to turn on" but "relevant parameters to be tuned"! 😄

The relevant parameters I was referring to are target_network_update_freq and training_intensity. Both are not part of the R2D2 paper and I've therefore ventured to tune them a little for the only learning regression test that we have for R2D2.
The relevant parameters should have been tuned when I introduced training intensity to R2D2, which was also when I introduced training_intensity.

Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how long does it take to train this on your laptop after the change?

@ArturNiederfahrenhorst
Copy link
Contributor Author

Hey @gjoliver ,
Before the changes: 150s
After the changes: 50s

@sven1977 sven1977 merged commit 35bd397 into ray-project:master Jun 7, 2022
sumanthratna pushed a commit to sumanthratna/ray that referenced this pull request Jun 8, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the r2d2fix branch July 5, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants