Skip to content

[workflow] Standardize workflow blocking and nonblocking APIs#26318

Merged
fishbone merged 1 commit intoray-project:masterfrom
suquark:unify_workflow_api
Jul 6, 2022
Merged

[workflow] Standardize workflow blocking and nonblocking APIs#26318
fishbone merged 1 commit intoray-project:masterfrom
suquark:unify_workflow_api

Conversation

@suquark
Copy link
Member

@suquark suquark commented Jul 6, 2022

Why are these changes needed?

This PR unified the semantics of some workflow APIs.

Those workflow APIs acts on workflow tasks so they could be blocked for a long time. So we have both the blocking and non-blocking versions for them: xxx for blocking and xxx_async for non-blocking APIs.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@suquark suquark changed the title [workflow] Unify workflow API [workflow] Unify workflow blocking and nonblocking APIs Jul 6, 2022
@suquark suquark changed the title [workflow] Unify workflow blocking and nonblocking APIs [workflow] Standardize workflow blocking and nonblocking APIs Jul 6, 2022
@fishbone fishbone merged commit b803792 into ray-project:master Jul 6, 2022
@suquark suquark deleted the unify_workflow_api branch July 6, 2022 21:52
@suquark suquark mentioned this pull request Jul 6, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants