Fix missing test data files dependency in rllib/BUILD#26520
Fix missing test data files dependency in rllib/BUILD#26520Riatre wants to merge 2 commits intoray-project:masterfrom
Conversation
|
To clarify, this PR should fix master, but it does not conflict with the rollback one (#26517) and I plan to roll-forward again with this change merged if the rollback happens. Please go ahead with the rollback if it unblocks you faster. Also, is there a good way to make sure all RLLib tests will be run for a pull request, so I can make sure it works in later roll-forward attempt? I missed this in #26334 because I didn't touch anything under |
|
Thanks for fixing this! Before we merge the new roll-forward PR, let's have one CI run where you just set all the variables in https://github.com/ray-project/ray/blob/master/ci/pipeline/determine_tests_to_run.py#L257 to 1 (you can do this in a temporary commit in the PR) to make sure we caught all such problems that can happen in advance :) |
See ray-project#26334 and ray-project#26517 for context. Once this is in, it should be good to roll-forwrad again.
Why are these changes needed?
See #26334 and #26517 for context.
Once this is in, it should be good to roll-forwrad again.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.